Skip to content

Conversation

mshockwave
Copy link
Member

@mshockwave mshockwave commented Apr 29, 2025

Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a check against Sscofpmf. NFC.


This is found by #137864

@mshockwave mshockwave requested a review from ppenzin April 29, 2025 19:15
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Apr 29, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 29, 2025

@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-backend-risc-v

@llvm/pr-subscribers-clang

Author: Min-Yih Hsu (mshockwave)

Changes

Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a test to check Sscofpmf. This is effectively an NFC.


This is found by #137864


Full diff: https://github.com/llvm/llvm-project/pull/137865.diff

2 Files Affected:

  • (modified) clang/test/Driver/riscv-cpus.c (+1)
  • (modified) llvm/lib/Target/RISCV/RISCVProcessors.td (-2)
diff --git a/clang/test/Driver/riscv-cpus.c b/clang/test/Driver/riscv-cpus.c
index bb3a9d38be673..6fa401203361e 100644
--- a/clang/test/Driver/riscv-cpus.c
+++ b/clang/test/Driver/riscv-cpus.c
@@ -251,6 +251,7 @@
 // MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+zvl256b"
 // MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+zvl32b"
 // MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+zvl64b"
+// MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+sscofpmf"
 // MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+svinval"
 // MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+svnapot"
 // MCPU-TT-ASCALON-D8-SAME: "-target-feature" "+svpbmt"
diff --git a/llvm/lib/Target/RISCV/RISCVProcessors.td b/llvm/lib/Target/RISCV/RISCVProcessors.td
index 1ad94228bcbaa..822c25a4e1130 100644
--- a/llvm/lib/Target/RISCV/RISCVProcessors.td
+++ b/llvm/lib/Target/RISCV/RISCVProcessors.td
@@ -480,11 +480,9 @@ def TENSTORRENT_ASCALON_D8 : RISCVProcessorModel<"tt-ascalon-d8",
                                                  !listconcat(RVA23S64Features,
                                                  [FeatureStdExtSmaia,
                                                   FeatureStdExtSsaia,
-                                                  FeatureStdExtSscofpmf,
                                                   FeatureStdExtSsstrict,
                                                   FeatureStdExtZfbfmin,
                                                   FeatureStdExtZfh,
-                                                  FeatureStdExtZicsr,
                                                   FeatureStdExtZvbc,
                                                   FeatureStdExtZvfbfmin,
                                                   FeatureStdExtZvfbfwma,

@lenary
Copy link
Member

lenary commented Apr 29, 2025

If the "-target-feature" "+sscofpmf" was already present in the test output, just not looked for, then I think you should just mark this as [NFC].

@mshockwave mshockwave changed the title [RISCV] Remove duplicate extensions from tt-ascalon-d8 CPU [RISCV][NFC] Remove duplicate extensions from tt-ascalon-d8 CPU Apr 29, 2025
@mshockwave
Copy link
Member Author

If the "-target-feature" "+sscofpmf" was already present in the test output, just not looked for, then I think you should just mark this as [NFC].

Agree. It's updated now.

@mshockwave mshockwave merged commit 74593f6 into llvm:main Apr 29, 2025
11 of 13 checks passed
@mshockwave mshockwave deleted the patch/riscv/tt-ascalon-d8-duplicate-feature branch April 29, 2025 21:19
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
…#137865)

Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a
check against Sscofpmf. NFC.
GeorgeARM pushed a commit to GeorgeARM/llvm-project that referenced this pull request May 7, 2025
…#137865)

Sscofpmf is already in RVA23S64 and Zicsr is in RVA20U64. I also added a
check against Sscofpmf. NFC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:RISC-V clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants