Skip to content

Conversation

@bubblepipe
Copy link
Contributor

"Replace all uses, but do not remote the operation yet" should be "Replace all uses, but do not remove the operation yet".

@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Apr 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 25, 2025

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: bubblepipe (bubblepipe)

Changes

"Replace all uses, but do not remote the operation yet" should be "Replace all uses, but do not remove the operation yet".


Full diff: https://github.com/llvm/llvm-project/pull/137341.diff

1 Files Affected:

  • (modified) mlir/lib/Transforms/CSE.cpp (+2-2)
diff --git a/mlir/lib/Transforms/CSE.cpp b/mlir/lib/Transforms/CSE.cpp
index 3affd88d158de..8e03f62894bab 100644
--- a/mlir/lib/Transforms/CSE.cpp
+++ b/mlir/lib/Transforms/CSE.cpp
@@ -140,7 +140,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
     if (auto *rewriteListener =
             dyn_cast_if_present<RewriterBase::Listener>(rewriter.getListener()))
       rewriteListener->notifyOperationReplaced(op, existing);
-    // Replace all uses, but do not remote the operation yet. This does not
+    // Replace all uses, but do not remove the operation yet. This does not
     // notify the listener because the original op is not erased.
     rewriter.replaceAllUsesWith(op->getResults(), existing->getResults());
     opsToErase.push_back(op);
@@ -156,7 +156,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
         if (all_of(v.getUses(), wasVisited))
           rewriteListener->notifyOperationReplaced(op, existing);
 
-    // Replace all uses, but do not remote the operation yet. This does not
+    // Replace all uses, but do not remove the operation yet. This does not
     // notify the listener because the original op is not erased.
     rewriter.replaceUsesWithIf(op->getResults(), existing->getResults(),
                                wasVisited);

@j2kun j2kun merged commit 3ce2d1e into llvm:main Apr 25, 2025
14 checks passed
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
"Replace all uses, but do not _remote_ the operation yet" should be
"Replace all uses, but do not _remove_ the operation yet".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mlir:core MLIR Core Infrastructure mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants