Skip to content

Disable some tests on bazel #132951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Disable some tests on bazel #132951

merged 2 commits into from
Mar 25, 2025

Conversation

googlewalt
Copy link
Contributor

These tests failed at Google after #130757. Disable them in bazel for the time being.

These tests failed at Google after llvm#130757.  Disable them in bazel for
the time being.
@googlewalt googlewalt requested review from lntue and harrisonGPU March 25, 2025 16:11
@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Mar 25, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 25, 2025

@llvm/pr-subscribers-libc

Author: Walter Lee (googlewalt)

Changes

These tests failed at Google after #130757. Disable them in bazel for the time being.


Full diff: https://github.com/llvm/llvm-project/pull/132951.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel (-20)
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index 377d8eb213f1e..f4c2bb06ff4dc 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -204,21 +204,6 @@ math_test(
     hdrs = ["FmaTest.h"],
 )
 
-math_test(
-    name = "f16fma",
-    hdrs = ["FmaTest.h"],
-)
-
-math_test(
-    name = "f16fmaf",
-    hdrs = ["FmaTest.h"],
-)
-
-math_test(
-    name = "f16fmal",
-    hdrs = ["FmaTest.h"],
-)
-
 math_test(
     name = "dmull",
     hdrs = ["MulTest.h"],
@@ -476,11 +461,6 @@ math_test(
 
 # TODO: Add fma, fmaf, fmal, fmaf128 tests.
 
-math_test(
-    name = "fmaf16",
-    hdrs = ["FmaTest.h"],
-)
-
 math_test(
     name = "fmax",
     hdrs = ["FMaxTest.h"],

@rupprecht
Copy link
Collaborator

I think it might be better to leave them in but commented out, to make it more visible that these tests exist but need to be fixed. But I'd defer to a libc reviewer's opinion.

@googlewalt
Copy link
Contributor Author

I think it might be better to leave them in but commented out, to make it more visible that these tests exist but need to be fixed. But I'd defer to a libc reviewer's opinion.

Fine with me. Done.

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I believe the fma tests in general have been having issues in Bazel

@googlewalt googlewalt merged commit 6ddc071 into llvm:main Mar 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants