[AMDGPU] Fix handling of FP in cs.chain functions #132711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there is an dynamic alloca / an alloca which is not in the entry block, cs.chain functions don't setup an FP, but are reported to need one. This results in a failed assertion in `SIFrameLowering::emitPrologue()` (Assertion `(!HasFP || FPSaved) && "Needed to save FP but didn't save it anywhere"' failed.) This commit changes `hasFPImpl` so that the need for an SP in a cs.chain function does not directly imply the need for an FP anymore. This LLVM defect was identified via the AMD Fuzzing project.
Contributor
Author
|
Closed for now since the IR is invalid for gfx942 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there is an dynamic alloca / an alloca which is not in the entry block, cs.chain functions don't setup an FP, but are reported to need one. This results in a failed assertion in
SIFrameLowering::emitPrologue()(Assertion(!HasFP || FPSaved) && "Needed to save FP but didn't save it anywhere"' failed.) This commit changeshasFPImpl` so that the need for an SP in a cs.chain function does not directly imply the need for an FP anymore.This LLVM defect was identified via the AMD Fuzzing project.
(@rovka as discussed :) )