gn build: libcxx: Sync file list and always define _LIBCPP_ABI_VERSION. #132135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
aeubanks
approved these changes
Mar 20, 2025
pcc
deleted the
users/pcc/spr/gn-build-libcxx-sync-file-list-and-always-define-_libcpp_abi_version
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 20, 2025
…_ABI_VERSION. The CMake side always defines _LIBCPP_ABI_VERSION. If we do not, we will at least get -Wundef warnings in the test suite (upgraded to errors) and it looks like we will end up building the library incorrectly as well. With that, most of the libc++ test suite passes (with a manually written lit.site.cfg) aside from some parts related to C++ modules which we don't support yet. Reviewers: nico, aeubanks Reviewed By: aeubanks Pull Request: llvm/llvm-project#132135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMake side always defines _LIBCPP_ABI_VERSION. If we do not, we will
at least get -Wundef warnings in the test suite (upgraded to errors)
and it looks like we will end up building the library incorrectly as well.
With that, most of the libc++ test suite passes (with a manually written
lit.site.cfg) aside from some parts related to C++ modules which we
don't support yet.