Skip to content

Conversation

frederick-vs-ja
Copy link
Contributor

The skipping was present before but dropped. At the time it was dropped in #128649, apple-clang-17 wasn't used for CI. But today it is used at least for the "macos (generic-cxx23, macos-15)" configuration. So I think we need to skip apple-clang-17 again.

The skipping was present before but dropped. At the time it was dropped,
apple-clang-17 wasn't used for CI. But today it is used at least for the
"macos (generic-cxx23, macos-15)" configuration. So I think we need to
skip apple-clang-17 again.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 14, 2025 10:51
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 14, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 14, 2025

@llvm/pr-subscribers-libcxx

Author: A. Jiang (frederick-vs-ja)

Changes

The skipping was present before but dropped. At the time it was dropped in #128649, apple-clang-17 wasn't used for CI. But today it is used at least for the "macos (generic-cxx23, macos-15)" configuration. So I think we need to skip apple-clang-17 again.


Full diff: https://github.com/llvm/llvm-project/pull/131302.diff

2 Files Affected:

  • (modified) libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp (+1-1)
  • (modified) libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp (+1-1)
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
index 24adec37431e7..681ad13a07dfd 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.pass.cpp
@@ -9,7 +9,7 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
 // These compilers don't support __builtin_is_implicit_lifetime yet.
-// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16
+// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16, apple-clang-17
 
 // <type_traits>
 
diff --git a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
index 4bcb10d0b7579..34462f9bf0ec6 100644
--- a/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
+++ b/libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/is_implicit_lifetime.verify.cpp
@@ -9,7 +9,7 @@
 // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
 
 // These compilers don't support __builtin_is_implicit_lifetime yet.
-// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16
+// UNSUPPORTED: clang-18, clang-19, gcc-14, apple-clang-15, apple-clang-16, apple-clang-17
 
 // <type_traits>
 

@frederick-vs-ja
Copy link
Contributor Author

Copy link
Contributor

@Zingam Zingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frederick-vs-ja frederick-vs-ja merged commit 999700c into llvm:main Mar 14, 2025
83 of 86 checks passed
@frederick-vs-ja frederick-vs-ja deleted the apple-clang-17-no-implicit-lifetime branch March 14, 2025 16:08
frederick-vs-ja added a commit that referenced this pull request Mar 15, 2025
…131438)

It seems that Apple Clang 17 starts to be used for CI, while it hasn't
supported `__builtin_is_virtual_base_of` yet. And thus we need to skip
the test for `is_virtual_base_of`.

Follows up #131302.
frederick-vs-ja added a commit to frederick-vs-ja/llvm-project that referenced this pull request Mar 16, 2025
…lvm#131438)

It seems that Apple Clang 17 starts to be used for CI, while it hasn't
supported `__builtin_is_virtual_base_of` yet. And thus we need to skip
the test for `is_virtual_base_of`.

Follows up llvm#131302.
@mordante
Copy link
Member

apple-clang-17 has been used today:

* https://github.com/llvm/llvm-project/actions/runs/13851155211/job/38763810513

@frederick-vs-ja or @ldionne do you know how we started using Apple-Clang-17? I also saw you backported fixes to the LLVM-20 branch. IMO we should really avoid using Apple-Clang-17 in LLVM-20. We also don't backport Clang-21 fixes to the LLVM-20 branch.

@frederick-vs-ja
Copy link
Contributor Author

apple-clang-17 has been used today:

* https://github.com/llvm/llvm-project/actions/runs/13851155211/job/38763810513

@frederick-vs-ja or @ldionne do you know how we started using Apple-Clang-17? I also saw you backported fixes to the LLVM-20 branch. IMO we should really avoid using Apple-Clang-17 in LLVM-20. We also don't backport Clang-21 fixes to the LLVM-20 branch.

Apple-Clang-17 started being used silently, and it seemed that Apple-Clang-16 and 17 were randomly chosen two days ago. I really didn't know how this happened...

swift-ci pushed a commit to swiftlang/llvm-project that referenced this pull request Mar 18, 2025
…lvm#131438)

It seems that Apple Clang 17 starts to be used for CI, while it hasn't
supported `__builtin_is_virtual_base_of` yet. And thus we need to skip
the test for `is_virtual_base_of`.

Follows up llvm#131302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. test-suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants