StandardInstrumentation: Fix -ir-dump-directory with -print-before-pass-number #130983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-number When using -print-before-pass-number, the result would still be printed to stderr instead of the file. This was due to pre-filtering cases where a temporary string for the filename prior to incrementing the current pass number. I found the tracking of this partial filename string confusing, so just defer that until the filename is really used. The ugliest piece of this is IRFileDisplayName - this needs to be computed on the original IR before before any invalidation.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arsenm
requested review from
aeubanks,
asl,
ellishg,
Flakebi,
kyulee-com,
NuriAmari and
paperchalice
arsenm
changed the title
NuriAmari
approved these changes
Mar 14, 2025
arsenm
deleted the
users/arsenm/fix-ir-dump-directory-with-print-before-pass-number
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using -print-before-pass-number, the result would still be
printed to stderr instead of the file. This was due to pre-filtering
cases where a temporary string for the filename prior to incrementing
the current pass number. I found the tracking of this partial filename string
confusing, so just defer that until the filename is really used.
The ugliest piece of this is IRFileDisplayName - this needs to be
computed on the original IR before before any invalidation.