[CodeGen][NPM] Port MachineSanitizerBinaryMetadata to NPM #130069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2025
Contributor
Author
This was referenced Mar 6, 2025
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_removeloadsintofakeuses_to_npm
branch
from
e986593 to
f06e7f4
Compare
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_machinesanitizerbinarymetadata_to_npm
branch
from
003ff87 to
5c5dde0
Compare
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_removeloadsintofakeuses_to_npm
branch
from
f06e7f4 to
ffd8728
Compare
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_machinesanitizerbinarymetadata_to_npm
branch
from
5c5dde0 to
ca3edf5
Compare
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_removeloadsintofakeuses_to_npm
branch
from
ffd8728 to
49cfcf2
Compare
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_machinesanitizerbinarymetadata_to_npm
branch
from
ca3edf5 to
2a60a24
Compare
arsenm
reviewed
Mar 10, 2025
| MachineFunctionAnalysisManager &MFAM) { | ||
| if (!MachineSanitizerBinaryMetadata().run(MF)) | ||
| return PreservedAnalyses::all(); | ||
| return getMachineFunctionPassPreservedAnalyses(); |
Contributor
There was a problem hiding this comment.
Looks like it should preserve nearly everything, particularly CFG
Contributor
There was a problem hiding this comment.
This pass also violates the assumption that machine passes never modify the underlying IR
cdevadas
approved these changes
Mar 10, 2025
Comment on lines
65
to
69
| return PreservedAnalyses::all(); | ||
| return getMachineFunctionPassPreservedAnalyses(); |
Collaborator
There was a problem hiding this comment.
Suggested change
| return PreservedAnalyses::all(); | |
| return getMachineFunctionPassPreservedAnalyses(); | |
| return PreservedAnalyses::all(); | |
| return getMachineFunctionPassPreservedAnalyses(); |
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_removeloadsintofakeuses_to_npm
branch
from
49cfcf2 to
10b5b57
Compare
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_machinesanitizerbinarymetadata_to_npm
branch
from
2a60a24 to
17c20b1
Compare
arsenm
approved these changes
Mar 11, 2025
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_removeloadsintofakeuses_to_npm
branch
from
10b5b57 to
edd9320
Compare
Base automatically changed from
users/optimisan/03-06-_codegen_npm_port_removeloadsintofakeuses_to_npm
to
main
April 14, 2025 07:28
optimisan
force-pushed
the
users/optimisan/03-06-_codegen_npm_port_machinesanitizerbinarymetadata_to_npm
branch
from
17c20b1 to
0bc54f7
Compare
optimisan
deleted the
users/optimisan/03-06-_codegen_npm_port_machinesanitizerbinarymetadata_to_npm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't find a test for this (but there are tests for the
Functionversion of this pass)