[SandboxIR][Region][NFC] Change visibility of Region::add()/remove() #129277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vectorizer's passes should not be allowed to manually add/remove elements. This should only be done automatically by the callbacks.
slackito
approved these changes
Feb 28, 2025
Collaborator
slackito
left a comment
slackito
left a comment
There was a problem hiding this comment.
The Attorney stuff in the test looks a bit uglier now, but if it helps prevent accidental misuse I'm fine with it.
Contributor
Author
Yeah, not sure if there is a better way around it. There may be a way to friend the tests perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vectorizer's passes should not be allowed to manually add/remove elements. This should only be done automatically by the callbacks.