-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[NFC][Cloning] Remove now unused CollectDebugInfoForCloning #129152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC][Cloning] Remove now unused CollectDebugInfoForCloning #129152
Conversation
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
23375fb to
d0782e5
Compare
e841dd1 to
4177775
Compare
|
@llvm/pr-subscribers-coroutines @llvm/pr-subscribers-llvm-transforms Author: Artem Pianykh (artempyanykh) ChangesStacked PRs:
[NFC][Cloning] Remove now unused CollectDebugInfoForCloningSummary: Test Plan: Full diff: https://github.com/llvm/llvm-project/pull/129152.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Transforms/Utils/Cloning.h b/llvm/include/llvm/Transforms/Utils/Cloning.h
index ae00c16e7eada..ec1a1d5faa7e9 100644
--- a/llvm/include/llvm/Transforms/Utils/Cloning.h
+++ b/llvm/include/llvm/Transforms/Utils/Cloning.h
@@ -230,20 +230,6 @@ void CloneAndPruneFunctionInto(Function *NewFunc, const Function *OldFunc,
const char *NameSuffix = "",
ClonedCodeInfo *CodeInfo = nullptr);
-/// Collect debug information such as types, compile units, and other
-/// subprograms that are reachable from \p F and can be considered global for
-/// the purposes of cloning (and hence not needing to be cloned).
-///
-/// What debug information should be processed depends on \p Changes: when
-/// cloning into the same module we process \p F's subprogram and instructions;
-/// when into a cloned module, neither of those.
-///
-/// Returns DISubprogram of the cloned function when cloning into the same
-/// module or nullptr otherwise.
-DISubprogram *CollectDebugInfoForCloning(const Function &F,
- CloneFunctionChangeType Changes,
- DebugInfoFinder &DIFinder);
-
/// This class captures the data input to the InlineFunction call, and records
/// the auxiliary results produced by it.
class InlineFunctionInfo {
diff --git a/llvm/lib/Transforms/Utils/CloneFunction.cpp b/llvm/lib/Transforms/Utils/CloneFunction.cpp
index 11033aeec7dda..f32d9454eb076 100644
--- a/llvm/lib/Transforms/Utils/CloneFunction.cpp
+++ b/llvm/lib/Transforms/Utils/CloneFunction.cpp
@@ -168,27 +168,6 @@ void llvm::CloneFunctionAttributesInto(Function *NewFunc,
OldAttrs.getRetAttrs(), NewArgAttrs));
}
-DISubprogram *llvm::CollectDebugInfoForCloning(const Function &F,
- CloneFunctionChangeType Changes,
- DebugInfoFinder &DIFinder) {
- // CloneModule takes care of cloning debug info for ClonedModule. Cloning into
- // DifferentModule is taken care of separately in ClonedFunctionInto as part
- // of llvm.dbg.cu update.
- if (Changes >= CloneFunctionChangeType::DifferentModule)
- return nullptr;
-
- DISubprogram *SPClonedWithinModule = nullptr;
- if (Changes < CloneFunctionChangeType::DifferentModule) {
- SPClonedWithinModule = F.getSubprogram();
- }
- if (SPClonedWithinModule)
- DIFinder.processSubprogram(SPClonedWithinModule);
-
- collectDebugInfoFromInstructions(F, DIFinder);
-
- return SPClonedWithinModule;
-}
-
void llvm::CloneFunctionMetadataInto(Function &NewFunc, const Function &OldFunc,
ValueToValueMapTy &VMap,
RemapFlags RemapFlag,
|
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: llvm/llvm-project#129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
felipepiovezan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4177775 to
f6168cf
Compare
f6168cf to
c670400
Compare
0ca9397 to
3b18ff8
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
c670400 to
395b2e4
Compare
3b18ff8 to
7c2cbfc
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
395b2e4 to
86a30c8
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
86a30c8 to
28f40fe
Compare
8b042ee to
1327301
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
28f40fe to
fbb3160
Compare
1327301 to
8e94559
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
fbb3160 to
0bb1f98
Compare
0bb1f98 to
4a68cde
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: llvm/llvm-project#129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
a415b77 to
ddb729c
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
4a68cde to
2688088
Compare
2688088 to
e2aef42
Compare
18be509 to
8da28de
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
e2aef42 to
6b37028
Compare
8da28de to
a597f7e
Compare
Summary: This function is no longer used, let's remove it from the header and impl. Test Plan: ninja check-llvm-unit stack-info: PR: #129152, branch: users/artempyanykh/fast-coro-upstream-part2-take2/10
6b37028 to
712ba5d
Compare
712ba5d to
9d5f7d8
Compare
Stacked PRs:
[NFC][Cloning] Remove now unused CollectDebugInfoForCloning
Summary:
This function is no longer used, let's remove it from the header and
impl.
Test Plan:
ninja check-llvm-unit