[flang][cmake] Fix bcc dependencies #125822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries().
|
@nikic, by the way, do you happen to know why MLIR uses |
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 5, 2025
The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries(). This fixes an issue introduced in llvm#120966. (cherry picked from commit f9af5c1)
nikic
added a commit
to nikic/llvm-project
that referenced
this pull request
Feb 11, 2025
The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries(). This fixes an issue introduced in llvm#120966. (cherry picked from commit f9af5c1)
Icohedron
pushed a commit
to Icohedron/llvm-project
that referenced
this pull request
Feb 11, 2025
The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries(). This fixes an issue introduced in llvm#120966.
Meinersbur
added a commit
that referenced
this pull request
Aug 6, 2025
It was overwritten due to an automatic merge gone wrong for #124416
Meinersbur
added a commit
that referenced
this pull request
Aug 6, 2025
This reverts commit 97cf061.
Meinersbur
pushed a commit
to Meinersbur/llvm-project
that referenced
this pull request
Aug 6, 2025
This was effectively reverted do to an automatic merge gone wrong for
Meinersbur
added a commit
to Meinersbur/llvm-project
that referenced
this pull request
Aug 6, 2025
This reverts commit f1af040.
Meinersbur
added a commit
that referenced
this pull request
Aug 6, 2025
Re-apply "[flang][cmake] Fix bcc dependencies (#125822)" It was overwritten due to an automatic merge gone wrong for #124416. `git cherry-pick f9af5c1` applied in 97cf061 ignored the renaming of FortranCommon into FortranSupport after #125822. Original commit message: The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries(). This fixes an issue introduced in #20966.
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 8, 2025
Re-apply "[flang][cmake] Fix bcc dependencies (llvm#125822)" It was overwritten due to an automatic merge gone wrong for llvm#124416. `git cherry-pick f9af5c1` applied in 97cf061 ignored the renaming of FortranCommon into FortranSupport after llvm#125822. Original commit message: The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries(). This fixes an issue introduced in llvm#20966. (cherry picked from commit 2bb23d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fortran libraries are not part of MLIR, so they should use target_link_libraries() rather than mlir_target_link_libraries().
This fixes an issue introduced in #120966. (This is the last one, I was able to build flang now \o/)