[Polly] Fix typos discovered by codespell #124545
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
| /// @param Prepend If true, will add @p Access before all other instructions | ||
| /// (instead of appending it). | ||
| void addAccess(MemoryAccess *Access, bool Preprend = false); | ||
| void addAccess(MemoryAccess *Access, bool Prepend = false); |
There was a problem hiding this comment.
Code change: Extra review, please.
This change matches with the correct spelling at:
llvm-project/polly/lib/Analysis/ScopInfo.cpp
Line 1127 in d7e561b
| return | ||
|
|
||
| self.__class__.initalized = True | ||
| self.__class__.initialized = True |
There was a problem hiding this comment.
Code change: Extra review, please.
This change matches with the correct spelling three lines above.
| return | ||
|
|
||
| self.__class__.initalized = True | ||
| self.__class__.initialized = True |
There was a problem hiding this comment.
Code change: Extra review, please.
This change matches with the correct spelling three lines above.
There was a problem hiding this comment.
Seems indeed an error that was supposed to avoid double initialization
cclauss
force-pushed
the
polly-codespell
branch
from
b730c4f to
e2e8aee
Compare
Meinersbur
changed the title
Meinersbur
left a comment
Meinersbur
left a comment
There was a problem hiding this comment.
LGTM, thank you
If you don't have push rights, please ping me and I will push the button for you.
| /// @param Prepend If true, will add @p Access before all other instructions | ||
| /// (instead of appending it). | ||
| void addAccess(MemoryAccess *Access, bool Preprend = false); | ||
| void addAccess(MemoryAccess *Access, bool Prepend = false); |
| return | ||
|
|
||
| self.__class__.initalized = True | ||
| self.__class__.initialized = True |
There was a problem hiding this comment.
Seems indeed an error that was supposed to avoid double initialization
|
I do not have push rights. Below it says:
|
|
@cclauss Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
Thanks for your contribution! |
2 participants
https://github.com/codespell-project/codespell
codespell polly --skip="*.pdf,polly/lib/External/*" --write-changes \ --ignore-words-list=couter,createor,distribues,doble,identty,indention,indx,olt,ore,padd,sais,te,theses@Meinersbur