Skip to content

PeepholeOpt: Remove unnecessary check for null TargetInstrInfo #123929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2025
Merged

PeepholeOpt: Remove unnecessary check for null TargetInstrInfo #123929

merged 2 commits into from
Jan 23, 2025

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Jan 22, 2025

This can never happen.

@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arsenm arsenm marked this pull request as ready for review January 22, 2025 11:16
jayfoad
jayfoad approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it works.

@jayfoad
Copy link
Contributor

jayfoad commented Jan 22, 2025

There are two other places in this file that check !TII. Can you remove those too?

This was referenced Jan 22, 2025
Merged
Merged
Merged
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 23, 2025 •
edited
Loading

Merge activity

  • Jan 22, 8:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 22, 8:37 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 8:42 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 8:45 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 8:47 PM EST: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/peephole-opt-do-not-check-null-tii branch 2 times, most recently from 09bedc3 to b8c1f4c Compare January 23, 2025 01:42
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-do-not-check-null-tii branch from b8c1f4c to c1b2b7e Compare January 23, 2025 01:45
@arsenm arsenm merged commit 23d2a18 into main Jan 23, 2025
5 of 7 checks passed
@arsenm arsenm deleted the users/arsenm/peephole-opt-do-not-check-null-tii branch January 23, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayfoad jayfoad jayfoad approved these changes

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes

@bwendling bwendling Awaiting requested review from bwendling

@kparzysz kparzysz Awaiting requested review from kparzysz

@MatzeB MatzeB Awaiting requested review from MatzeB

@Pierre-vh Pierre-vh Awaiting requested review from Pierre-vh

@qcolombet qcolombet Awaiting requested review from qcolombet

Assignees

No one assigned

Labels

llvm:codegen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arsenm @jayfoad