Skip to content

[MC] Unhide the target-abi option. #123135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Jan 15, 2025

This option is very important for RISC-V as it controls calling convention and a field in the ELF header. It is used in a large number of RISC-V lit tests.

Expose the option to -help.

Fixes one issue raised in #123077

This option is very important for RISC-V as it controls calling
convention and a field in the ELF header. It is used in a large
number of RISC-V lit tests.

Expose the option to -help.
@llvmbot llvmbot added the mc Machine (object) code label Jan 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 15, 2025

@llvm/pr-subscribers-mc

Author: Craig Topper (topperc)

Changes

This option is very important for RISC-V as it controls calling convention and a field in the ELF header. It is used in a large number of RISC-V lit tests.

Expose the option to -help.


Full diff: https://github.com/llvm/llvm-project/pull/123135.diff

1 Files Affected:

  • (modified) llvm/lib/MC/MCTargetOptionsCommandFlags.cpp (+1-1)
diff --git a/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp b/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp
index abaf0f0246183e..2adc29172f9ddf 100644
--- a/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp
+++ b/llvm/lib/MC/MCTargetOptionsCommandFlags.cpp
@@ -156,7 +156,7 @@ llvm::mc::RegisterMCTargetOptionsFlags::RegisterMCTargetOptionsFlags() {
   MCBINDOPT(X86Sse2Avx);
 
   static cl::opt<std::string> ABIName(
-      "target-abi", cl::Hidden,
+      "target-abi",
       cl::desc("The name of the ABI to be targeted from the backend."),
       cl::init(""));
   MCBINDOPT(ABIName);

Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this all the time and didn't know it was hidden. Making it visible is a good improvement!

@topperc topperc merged commit 98dbce3 into llvm:main Jan 16, 2025
10 checks passed
@topperc topperc deleted the pr/target-abi-unhide branch January 16, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants