[BOLT][AArch64] Speedup computeInstructionSize
#121106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liusy58
requested review from
aaupov,
maksfb,
rafaelauler,
ayermolo,
dcci and
yota9
as code owners
|
@llvm/pr-subscribers-bolt Author: Nicholas (liusy58) ChangesAArch64 instructions has a fixed size 4 bytes, no need to compute. Full diff: https://github.com/llvm/llvm-project/pull/121106.diff 1 Files Affected:
diff --git a/bolt/include/bolt/Core/BinaryContext.h b/bolt/include/bolt/Core/BinaryContext.h
index 115e59ca0697e5..22764098700214 100644
--- a/bolt/include/bolt/Core/BinaryContext.h
+++ b/bolt/include/bolt/Core/BinaryContext.h
@@ -1362,7 +1362,15 @@ class BinaryContext {
const MCCodeEmitter *Emitter = nullptr) const {
if (std::optional<uint32_t> Size = MIB->getSize(Inst))
return *Size;
-
+ // Pseudo instrs will not be emiitted and have no size.
+ if (MIB->isPseudo(Inst)) {
+ return 0;
+ }
+ // Directly return 4 because AArch64 instructions always have a
+ // fixed size of 4 bytes.
+ if (isAArch64()) {
+ return 4;
+ }
if (!Emitter)
Emitter = this->MCE.get();
SmallString<256> Code;
|
|
Every patch requires testing, but I haven't found a suitable way to evaluate its performance. Any suggestions |
yavtuk
reviewed
Dec 25, 2024
liusy58
force-pushed
the
test
branch
5 times, most recently
from
e39baaf to
903b4a8
Compare
yota9
reviewed
Jan 9, 2025
|
|
||
| std::optional<uint32_t> | ||
| getInstructionSize(const MCInst &Inst) const override { | ||
| if (isPseudo(Inst)) { |
There was a problem hiding this comment.
Suggested change
| if (isPseudo(Inst)) { | |
| if (isPseudo(Inst)) | |
| return 0; | |
| return 4; |
There was a problem hiding this comment.
BTW maybe move isPseudo check to computeInstructionSize?
yota9
reviewed
Jan 9, 2025
|
@yota9 hi, I have updated, please review again! |
liusy58
added a commit
to liusy58/llvm-project
that referenced
this pull request
Jan 17, 2025
AArch64 instructions have a fixed size 4 bytes, no need to compute.
liusy58
added a commit
to liusy58/llvm-project
that referenced
this pull request
Jan 17, 2025
AArch64 instructions have a fixed size 4 bytes, no need to compute.
liusy58
added a commit
to liusy58/llvm-project
that referenced
this pull request
Jan 17, 2025
AArch64 instructions have a fixed size 4 bytes, no need to compute.
liusy58
added a commit
to liusy58/llvm-project
that referenced
this pull request
Jan 17, 2025
AArch64 instructions have a fixed size 4 bytes, no need to compute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AArch64 instructions have a fixed size 4 bytes, no need to compute.