Skip to content

[clang-cl] Don't add implicit NoBuiltinAttr to deleted or defaulted functions #119719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[clang-cl] Don't add implicit NoBuiltinAttr to deleted or defaulted functions #119719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clang/lib/Sema/SemaAttr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,6 +1310,8 @@ void Sema::AddOptnoneAttributeIfNoConflicts(FunctionDecl *FD,
}

void Sema::AddImplicitMSFunctionNoBuiltinAttr(FunctionDecl *FD) {
if (FD->isDeleted() || FD->isDefaulted())
return;
SmallVector<StringRef> V(MSFunctionNoBuiltins.begin(),
MSFunctionNoBuiltins.end());
if (!MSFunctionNoBuiltins.empty())
Expand Down
32 changes: 32 additions & 0 deletions clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// RUN: %clang_cl -fms-compatibility -Xclang -ast-dump -fsyntax-only %s | FileCheck %s

extern "C" __inline float __cdecl fabsf( float _X);
// CHECK: FunctionDecl {{.*}} fabsf
#pragma function(fabsf)
__inline float __cdecl fabsf( float _X)
{
return 0;
}
// CHECK: FunctionDecl {{.*}} fabsf
// CHECK: NoBuiltinAttr {{.*}} <<invalid sloc>> Implicit fabsf

int bar() {
return 0;
}
// CHECK: FunctionDecl {{.*}} bar
// CHECK: NoBuiltinAttr {{.*}} <<invalid sloc>> Implicit fabsf

struct A {
int foo() = delete;
// CHECK: CXXMethodDecl {{.*}} foo 'int ()' delete
// CHECK-NOT: NoBuiltinAttr
A() = default;
// CHECK: CXXConstructorDecl {{.*}} A 'void ()' default
// CHECK-NOT: NoBuiltinAttr
};

int main() {
return 0;
}
// CHECK: FunctionDecl {{.*}} main
// CHECK: NoBuiltinAttr {{.*}} <<invalid sloc>> Implicit fabsf
Loading