Skip to content

Improve slightly the pre-commit git hook usage of the auto-format helper #117326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Improve slightly the pre-commit git hook usage of the auto-format helper #117326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion llvm/utils/git/code-format-helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ def format_run(self, changed_files: List[str], args: FormatArgs) -> Optional[str
def hook_main():
# fill out args
args = FormatArgs()
args.verbose = False
args.verbose = os.getenv("FORMAT_HOOK_VERBOSE", False)

# find the changed files
cmd = ["git", "diff", "--cached", "--name-only", "--diff-filter=d"]
Expand All @@ -338,6 +338,9 @@ def hook_main():
print(f"Couldn't find {fmt.name}, can't check " + fmt.friendly_name.lower())

if len(failed_fmts) > 0:
print(
"Pre-commit format hook failed, rerun with FORMAT_HOOK_VERBOSE=1 environment for verbose output"
)
sys.exit(1)

sys.exit(0)
Expand Down
Loading