[analyzer] Print the PostInitializer target in exploded-graph-rewriter #116034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) ChangesThis aids debugging PostInitializer program points by knowing what is the location being initialized.
Full diff: https://github.com/llvm/llvm-project/pull/116034.diff 1 Files Affected:
diff --git a/clang/utils/analyzer/exploded-graph-rewriter.py b/clang/utils/analyzer/exploded-graph-rewriter.py
index 5eaa7738103f79..2eff20fd5899f3 100755
--- a/clang/utils/analyzer/exploded-graph-rewriter.py
+++ b/clang/utils/analyzer/exploded-graph-rewriter.py
@@ -88,6 +88,8 @@ def __init__(self, json_pp):
)
elif self.kind == "BlockEntrance":
self.block_id = json_pp["block_id"]
+ elif self.kind == "PostInitializer":
+ self.target = json_pp["field_decl"] if "field_decl" in json_pp else json_pp["type"]
# A single expression acting as a key in a deserialized Environment.
@@ -618,6 +620,13 @@ def visit_program_point(self, p):
'<font color="%s">%s</font></td>'
'<td align="left">[B%d]</td></tr>' % (color, p.kind, p.block_id)
)
+ elif p.kind == "PostInitializer":
+ self._dump(
+ '<td width="0"></td>'
+ '<td align="left" width="0">'
+ '<font color="%s">%s</font></td>'
+ '<td align="left">%s</td></tr>' % (color, p.kind, p.target)
+ )
else:
# TODO: Print more stuff for other kinds of points.
self._dump(
|
|
✅ With the latest revision this PR passed the Python code formatter. |
This aids debugging PostInitializer program points by knowing what is the location being initialized.
Contributor
Author
|
Ping @NagyDonat |
NagyDonat
approved these changes
Nov 22, 2024
Contributor
NagyDonat
left a comment
NagyDonat
left a comment
There was a problem hiding this comment.
Sorry for missing this review, I didn't noticed that this is distinct from the similar CallEnter change.
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/9118 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aids debugging PostInitializer program points by knowing what is the location being initialized.