[CAS] Add ActionCache to LLVMCAS Library #114097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5 [skip ci]
Created using spr 1.3.5
This was referenced Oct 29, 2024
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
cachemeifyoucan
changed the base branch from
users/cachemeifyoucan/spr/main.cas-add-actioncache-to-llvmcas-library
to
main
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
cachemeifyoucan
requested review from
adrian-prantl,
bogner,
ilovepi and
rastogishubham
Created using spr 1.3.6
Collaborator
Author
|
This is ready for review. ActionCache API added into LLVMCAS library. |
ilovepi
reviewed
Aug 13, 2025
Created using spr 1.3.6
Created using spr 1.3.6
Created using spr 1.3.6
…e-to-llvmcas-library
adrian-prantl
approved these changes
Aug 18, 2025
Collaborator
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
LGTM with some minor nitpicking...
Created using spr 1.3.6
Collaborator
Author
|
Ping. If no more comments, I will merge today. |
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/cas-add-actioncache-to-llvmcas-library
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionCache is used to store a mapping from CASID to CASID. The current
implementation of the ActionCache can only be used to associate the
key/value from the same hash context.
ActionCache has two operations:
putto store the key/value andgettolookup the key/value mapping. ActionCache uses the same TrieRawHashMap
data structure to store the mapping, where is CASID of the key is the
hash to index the map.
While CASIDs for key/value are often associcate with actual CAS
ObjectStore, it doesn't provide the guarantee of the existence of such
object in any ObjectStore.