Skip to content

Conversation

@ldionne
Copy link
Member

@ldionne ldionne commented Oct 3, 2024

This variable isn't used anymore in libc++'s build and hasn't been for a few years, so this is likely a remnant of the past.

This variable isn't used anymore in libc++'s build and hasn't been
for a few years, so this is likely a remnant of the past.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 3, 2024
@ldionne ldionne requested a review from rprichard October 3, 2024 15:29
@llvmbot
Copy link
Member

llvmbot commented Oct 3, 2024

@llvm/pr-subscribers-clang

Author: Louis Dionne (ldionne)

Changes

This variable isn't used anymore in libc++'s build and hasn't been for a few years, so this is likely a remnant of the past.


Full diff: https://github.com/llvm/llvm-project/pull/111007.diff

1 Files Affected:

  • (modified) clang/cmake/caches/Android.cmake (-1)
diff --git a/clang/cmake/caches/Android.cmake b/clang/cmake/caches/Android.cmake
index 9e15fff0337612..d5ca6b50d4ada7 100644
--- a/clang/cmake/caches/Android.cmake
+++ b/clang/cmake/caches/Android.cmake
@@ -9,7 +9,6 @@ set(CLANG_VENDOR Android CACHE STRING "")
 
 set(CMAKE_BUILD_TYPE RELEASE CACHE STRING "")
 
-set(HAVE_LIBCXXABI ON CACHE BOOL "")
 set(LLVM_BUILD_TOOLS OFF CACHE BOOL "")
 set(LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "")
 set(LLVM_ENABLE_THREADS OFF CACHE BOOL "")

@ldionne ldionne merged commit 7e31eaa into llvm:main Oct 8, 2024
10 checks passed
@ldionne ldionne deleted the review/remove-have-cxxabi branch October 8, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants