Skip to content

Conversation

philnik777
Copy link
Contributor

Support for __is_nullptr was removed in #99038, but I forgot to remove it from the list of type traits, resulting in Clang crashing when one tries to use it.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 21, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 21, 2024

@llvm/pr-subscribers-clang

Author: Nikolas Klauser (philnik777)

Changes

Support for __is_nullptr was removed in #99038, but I forgot to remove it from the list of type traits, resulting in Clang crashing when one tries to use it.


Full diff: https://github.com/llvm/llvm-project/pull/109533.diff

1 Files Affected:

  • (modified) clang/include/clang/Basic/TokenKinds.def (-1)
diff --git a/clang/include/clang/Basic/TokenKinds.def b/clang/include/clang/Basic/TokenKinds.def
index 00e150dbd7a3a7..c5c3838407cf48 100644
--- a/clang/include/clang/Basic/TokenKinds.def
+++ b/clang/include/clang/Basic/TokenKinds.def
@@ -542,7 +542,6 @@ TYPE_TRAIT_1(__is_trivially_relocatable, IsTriviallyRelocatable, KEYCXX)
 TYPE_TRAIT_1(__is_trivially_equality_comparable, IsTriviallyEqualityComparable, KEYCXX)
 TYPE_TRAIT_1(__is_bounded_array, IsBoundedArray, KEYCXX)
 TYPE_TRAIT_1(__is_unbounded_array, IsUnboundedArray, KEYCXX)
-TYPE_TRAIT_1(__is_nullptr, IsNullPointer, KEYCXX)
 TYPE_TRAIT_1(__is_scoped_enum, IsScopedEnum, KEYCXX)
 TYPE_TRAIT_1(__is_referenceable, IsReferenceable, KEYCXX)
 TYPE_TRAIT_1(__can_pass_in_regs, CanPassInRegs, KEYCXX)

@philnik777 philnik777 merged commit 2f1e04f into llvm:main Sep 22, 2024
11 checks passed
@philnik777 philnik777 deleted the fix_is_nullptr branch October 6, 2024 17:11
steven-studio pushed a commit to steven-studio/llvm-project that referenced this pull request Sep 11, 2025
Support for `__is_nullptr` was removed in llvm#99038, but I forgot to remove
it from the list of type traits, resulting in Clang crashing when one
tries to use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants