Skip to content

Conversation

@MalaySanghi
Copy link
Contributor

This patch simply remove the -emit-llvm option as this testcase don't care about the outputed llvm IR.
The current directory may be write protected e.g. in a sandboxed environment.

This patch simply remove the -emit-llvm option as this testcase don't
care about the outputed llvm IR.
The current directory may be write protected e.g. in
a sandboxed environment.
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:X86 labels Sep 13, 2024
@MalaySanghi
Copy link
Contributor Author

@phoebewang please review

@llvmbot
Copy link
Member

llvmbot commented Sep 13, 2024

@llvm/pr-subscribers-backend-x86

@llvm/pr-subscribers-clang

Author: Malay Sanghi (MalaySanghi)

Changes

This patch simply remove the -emit-llvm option as this testcase don't care about the outputed llvm IR.
The current directory may be write protected e.g. in a sandboxed environment.


Full diff: https://github.com/llvm/llvm-project/pull/108525.diff

2 Files Affected:

  • (modified) clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-errors.c (+2-2)
  • (modified) clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-x64-error.c (+1-1)
diff --git a/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-errors.c b/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-errors.c
index c2e891217fbbcf..a5c45914cdf7d1 100644
--- a/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-errors.c
+++ b/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-errors.c
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=i386-unknown-unknown -target-feature +avx10.2-512 -emit-llvm -Wall -Werror -verify
+// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=i386-unknown-unknown -target-feature +avx10.2-512 -Wall -Werror -verify
 
 #include <immintrin.h>
 #include <stddef.h>
@@ -49,4 +49,4 @@ __m512i test_mm512_mask_cvtts_roundps_epu32(__m512i W, __mmask8 U, __m512 A) {
 
 __m512i test_mm512_maskz_cvtts_roundps_epu32(__mmask8 U, __m512 A) {
   return _mm512_maskz_cvtts_roundps_epu32(U, A, 22); // expected-error {{invalid rounding argument}}
-}
\ No newline at end of file
+}
diff --git a/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-x64-error.c b/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-x64-error.c
index 2900256914570c..334edfb501e2f0 100755
--- a/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-x64-error.c
+++ b/clang/test/CodeGen/X86/avx10_2_512satcvtds-builtins-x64-error.c
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx10.2-512 -emit-llvm -Wall -Werror -verify
+// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx10.2-512 -Wall -Werror -verify
 
 #include <immintrin.h>
 #include <stddef.h>

@metaflow
Copy link
Contributor

there is also avx10_2satcvtds-builtins-errors.c that calls emit

@metaflow
Copy link
Contributor

thank you for the fix @MalaySanghi !

@metaflow
Copy link
Contributor

I have submitted it as a41bb71 (with 3 files). Sorry for the race, but I want it working :)

@MalaySanghi
Copy link
Contributor Author

I have submitted it as a41bb71 (with 3 files). Sorry for the race, but I want it working :)

Apologies for missing that file and thanks for taking this up.

@MalaySanghi MalaySanghi deleted the ms_fixtest branch November 6, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:X86 clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants