Skip to content

Conversation

@H-G-Hristov
Copy link
Contributor

@H-G-Hristov H-G-Hristov commented Sep 8, 2024

https://wg21.link/p1869r1: Rename condition_variable_any interruptible wait methods

The paper was implemented as experimental feature in Clang 18 in: 4fa812b

Experimental status removed in: #107900

Closes #100031

The paper was implemented as experimental feature in Clang 18 in: llvm@4fa812b

Closes llvm#100031
@Zingam Zingam marked this pull request as ready for review September 8, 2024 08:52
@Zingam Zingam requested a review from a team as a code owner September 8, 2024 08:52
@Zingam Zingam requested a review from huixie90 September 8, 2024 08:52
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Sep 8, 2024
@Zingam Zingam requested a review from ldionne September 8, 2024 08:53
@llvmbot
Copy link
Member

llvmbot commented Sep 8, 2024

@llvm/pr-subscribers-libcxx

Author: Hristo Hristov (H-G-Hristov)

Changes

The paper was implemented as experimental feature in Clang 18 in: 4fa812b

Closes #100031


Full diff: https://github.com/llvm/llvm-project/pull/107746.diff

1 Files Affected:

  • (modified) libcxx/docs/Status/Cxx20Papers.csv (+1-1)
diff --git a/libcxx/docs/Status/Cxx20Papers.csv b/libcxx/docs/Status/Cxx20Papers.csv
index ad788d7416fdad..4a40a21247e485 100644
--- a/libcxx/docs/Status/Cxx20Papers.csv
+++ b/libcxx/docs/Status/Cxx20Papers.csv
@@ -152,7 +152,7 @@
 "`P1855R0 <https://wg21.link/P1855R0>`__","Make ``<compare>``\  freestanding","2019-11 (Belfast)","","",""
 "`P1862R1 <https://wg21.link/P1862R1>`__","Ranges adaptors for non-copyable iterators","2019-11 (Belfast)","|Complete|","16.0",""
 "`P1865R1 <https://wg21.link/P1865R1>`__","Add max() to latch and barrier","2019-11 (Belfast)","|Complete|","11.0",""
-"`P1869R1 <https://wg21.link/P1869R1>`__","Rename 'condition_variable_any' interruptible wait methods","2019-11 (Belfast)","","",""
+"`P1869R1 <https://wg21.link/P1869R1>`__","Rename 'condition_variable_any' interruptible wait methods","2019-11 (Belfast)","|Complete|","18.0","The paper is implemented but the features are experimental and can be enabled via ``-fexperimental-library``."
 "`P1870R1 <https://wg21.link/P1870R1>`__","forwarding-range is too subtle","2019-11 (Belfast)","|Complete|","15.0",""
 "`P1871R1 <https://wg21.link/P1871R1>`__","Concept traits should be named after concepts","2019-11 (Belfast)","|Complete|","14.0",""
 "`P1872R0 <https://wg21.link/P1872R0>`__","span should have size_type, not index_type","2019-11 (Belfast)","|Complete|","10.0",""

@ldionne
Copy link
Member

ldionne commented Sep 9, 2024

Relevant: #107900

Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just wait for #107900 to land.

@Zingam
Copy link
Contributor

Zingam commented Sep 13, 2024

LGTM, let's just wait for #107900 to land.

Thank you. It looks like this is good to go.

@Zingam Zingam merged commit 51f5525 into llvm:main Sep 13, 2024
@H-G-Hristov H-G-Hristov deleted the hgh/libcxx/P1869R1-NFC-Mark-as-implemented branch September 14, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P1869R1: Rename condition_variable_any interruptible wait methods

5 participants