Skip to content

[LTO] Modernize AliasSummary and ModuleSummaryIndex (NFC) #107633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[LTO] Modernize AliasSummary and ModuleSummaryIndex (NFC) #107633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions llvm/include/llvm/IR/ModuleSummaryIndex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,12 +640,11 @@ class AliasSummary : public GlobalValueSummary {
/// memory for time). Note that this pointer may be null (and the value info
/// empty) when we have a distributed index where the alias is being imported
/// (as a copy of the aliasee), but the aliasee is not.
GlobalValueSummary *AliaseeSummary;
GlobalValueSummary *AliaseeSummary = nullptr;

public:
AliasSummary(GVFlags Flags)
: GlobalValueSummary(AliasKind, Flags, SmallVector<ValueInfo, 0>{}),
AliaseeSummary(nullptr) {}
: GlobalValueSummary(AliasKind, Flags, SmallVector<ValueInfo, 0>{}) {}

/// Check if this is an alias summary.
static bool classof(const GlobalValueSummary *GVS) {
Expand Down Expand Up @@ -1420,7 +1419,7 @@ class ModuleSummaryIndex {
// used except in the case of a SamplePGO partial profile, and should be
// reevaluated/redesigned to allow more effective incremental builds in that
// case.
uint64_t BlockCount;
uint64_t BlockCount = 0;

// List of unique stack ids (hashes). We use a 4B index of the id in the
// stack id lists on the alloc and callsite summaries for memory savings,
Expand All @@ -1446,7 +1445,7 @@ class ModuleSummaryIndex {
ModuleSummaryIndex(bool HaveGVs, bool EnableSplitLTOUnit = false,
bool UnifiedLTO = false)
: HaveGVs(HaveGVs), EnableSplitLTOUnit(EnableSplitLTOUnit),
UnifiedLTO(UnifiedLTO), Saver(Alloc), BlockCount(0) {}
UnifiedLTO(UnifiedLTO), Saver(Alloc) {}

// Current version for the module summary in bitcode files.
// The BitcodeSummaryVersion should be bumped whenever we introduce changes
Expand Down