Skip to content

[CMake][Support] Use /nologo when compiling BLAKE3 assembly sources on Windows #106794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2024
Merged

[CMake][Support] Use /nologo when compiling BLAKE3 assembly sources on Windows #106794

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b06d64
[CMake] Suppresses ml64 printing
MattBolitho Aug 30, 2024
a2ec809
Uses /nologo only
MattBolitho Aug 30, 2024
6e7c968
Removes foreach and adjusts comment
MattBolitho Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion llvm/lib/Support/BLAKE3/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,16 @@ if (CAN_USE_ASSEMBLER)
check_symbol_exists(_M_X64 "" IS_X64)
if (IS_X64)
enable_language(ASM_MASM)
list(APPEND LLVM_BLAKE3_FILES
set(LLVM_BLAKE3_ASM_FILES
blake3_sse2_x86-64_windows_msvc.asm
blake3_sse41_x86-64_windows_msvc.asm
blake3_avx2_x86-64_windows_msvc.asm
blake3_avx512_x86-64_windows_msvc.asm
)
list(APPEND LLVM_BLAKE3_FILES ${LLVM_BLAKE3_ASM_FILES})
# Supress the copyright message.
set_source_files_properties(${LLVM_BLAKE3_ASM_FILES}
PROPERTIES COMPILE_OPTIONS "/nologo")
else()
disable_blake3_x86_simd()
endif()
Expand Down