[SandboxIR] Implement ConstantFP #106648
Merged
[SandboxIR] Implement ConstantFP #106648
+303
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
requested review from
Sterling-Augustine,
aeubanks,
alinas,
slackito,
tmsri and
tschuett
vporpo
force-pushed
the
SBVec
branch
2 times, most recently
from
f48ede8 to
ec390b3
Compare
tmsri
reviewed
Aug 30, 2024
| return From->getSubclassID() == ClassID::ConstantFP; | ||
| } | ||
|
|
||
| unsigned getUseOperandNo(const Use &Use) const final { |
Member
There was a problem hiding this comment.
I am trying to match this with LLVM IR. Why not just call this "getOperandNo" with the Use as parameter?
Contributor
Author
There was a problem hiding this comment.
This is a SandboxIR-specific function, it is not wrapping any LLVM IR one. We should probably make this private at some point. But yeah getOperandNo(const Use &) is a much better name.
tmsri
approved these changes
Aug 30, 2024
Member
tmsri
left a comment
tmsri
left a comment
There was a problem hiding this comment.
LGTM otherwise, having TODOs in all places where you expect a cleanup would be very useful.
This patch implements sandboxir::ConstantFP mirroring llvm::ConstantFP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements sandboxir::ConstantFP mirroring llvm::ConstantFP.