Skip to content

[test] Prevent generation of the bigendian code inside clang test CodeGen/bit-int-ubsan.c #104607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 16, 2024
Merged

[test] Prevent generation of the bigendian code inside clang test CodeGen/bit-int-ubsan.c #104607

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
98d3d53
[ubsan] Display correct runtime messages for negative _BitInt
Aug 7, 2024
2ba516a
Merge branch 'llvm:main' into main
earnol Aug 15, 2024
4de0f7e
[bitint] Fix test error due to CRT dependency
Aug 15, 2024
0f15cfb
[test] Update CodeGen/bit-int-ubsan to invoke only frontend
Aug 15, 2024
0c2cbba
[ubsan] Limit runtime tests to x86-64 target only
Aug 15, 2024
5adf01b
Update bit-int.c
vitalybuka Aug 15, 2024
4aac3cd
[test] Prevent generation of the big-endian code
Aug 16, 2024
3702b7f
Merge branch 'main' into main
earnol Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/test/CodeGen/bit-int-ubsan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// REQUIRES: x86-registered-target
Copy link
Contributor

@nikic nikic Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this REQUIRED needed? You normally do not need the backend to be available for clang codegen tests.

Copy link
Contributor Author

@earnol earnol Aug 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It present in other tests which are target specific. Anyways this test will not work properly for targets with big endianness. So it is required.

// RUN: %clang_cc1 -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -fsanitize=array-bounds,enum,float-cast-overflow,integer-divide-by-zero,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation,implicit-integer-sign-change,unsigned-integer-overflow,signed-integer-overflow,shift-base,shift-exponent -O0 -emit-llvm -o - %s | FileCheck %s
// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -fsanitize=array-bounds,enum,float-cast-overflow,integer-divide-by-zero,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation,implicit-integer-sign-change,unsigned-integer-overflow,signed-integer-overflow,shift-base,shift-exponent -O0 -emit-llvm -o - %s | FileCheck %s

// The runtime test checking the _BitInt ubsan feature is located in compiler-rt/test/ubsan/TestCases/Integer/bit-int.c

Expand Down