Skip to content

[llvm-lit] Fix Unhashable TypeError when using lit's internal shell #101590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 14, 2024
Merged

[llvm-lit] Fix Unhashable TypeError when using lit's internal shell #101590

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7aab48
[llvm-lit] Unhashable type Support
Harini0924 Jul 31, 2024
2bb5b51
Merge branch 'main' into fixing_unhasable
Harini0924 Aug 7, 2024
2408040
[llvm-lit] Fix handling of GlobItem in args[0] to ensure it is hashable
Harini0924 Aug 7, 2024
25b1bd7
[llvm-lit] Simplify args[0] Hashability Check and Expansion
Harini0924 Aug 8, 2024
bdea995
[llvm-lit] Fixed a comment
Harini0924 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/utils/lit/lit/TestRunner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,10 @@ def _executeShCmd(cmd, shenv, results, timeoutHelper):
# echo-appending to a file.
# FIXME: Standardize on the builtin echo implementation. We can use a
# temporary file to sidestep blocking pipe write issues.

# Ensure args[0] is hashable.
args[0] = expand_glob(args[0], cmd_shenv.cwd)[0]

inproc_builtin = inproc_builtins.get(args[0], None)
if inproc_builtin and (args[0] != "echo" or len(cmd.commands) == 1):
# env calling an in-process builtin is useless, so we take the safe
Expand Down