Skip to content

[SandboxIR][NFC] Fixes for LoadInst::create functions #100955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 29, 2024
Merged

[SandboxIR][NFC] Fixes for LoadInst::create functions #100955

merged 6 commits into from
Jul 29, 2024

Conversation

@wizardengineer
Copy link
Contributor

@wizardengineer wizardengineer commented Jul 29, 2024

Changes were discussed here: #100850 (comment)

cc: @vporpo

@github-actions
Copy link

github-actions bot commented Jul 29, 2024

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@wizardengineer wizardengineer changed the title [SandboxIR][NFC] Fixes for functions LoadInst::create [SandboxIR][NFC] Fixes for LoadInst::create functions Jul 29, 2024
vporpo
vporpo reviewed Jul 29, 2024
View reviewed changes
wizardengineer
wizardengineer commented Jul 29, 2024
View reviewed changes
vporpo
vporpo reviewed Jul 29, 2024
View reviewed changes
vporpo
vporpo reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@vporpo vporpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, looks good otherwise.

vporpo
vporpo reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@vporpo vporpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more minor comments.

vporpo
vporpo approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@vporpo vporpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I will merge it as soon as the bots pass.

@vporpo
Copy link
Contributor

vporpo commented Jul 29, 2024

Btw isVolatile is also missing from StoreInst, so feel free to update that as well.

@wizardengineer
Copy link
Contributor Author

wizardengineer commented Jul 29, 2024 •
edited
Loading

Btw isVolatile is also missing from StoreInst, so feel free to update that as well.

StoreInst: #100961 (btw, I have to add similar changes to the ones you discussed here onto the StoreInst PR. Mainly the test.)

@vporpo if it's okay with you, I needed help with understanding why the bot checks were failing for the StoreInst PR I created. if you have time are you able to check it out for me? I was struggling to find a fix.

@wizardengineer wizardengineer requested a review from vporpo July 29, 2024 19:12
@vporpo vporpo merged commit b3b390b into llvm:main Jul 29, 2024
@wizardengineer wizardengineer deleted the _SandboxIR_NFC_Added_more_functions branch July 29, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vporpo vporpo Awaiting requested review from vporpo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wizardengineer @vporpo