Skip to content

[InstCombine] Use more inline elements in a SmallVector #100942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024
Merged

[InstCombine] Use more inline elements in a SmallVector #100942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,7 @@ Instruction *InstCombinerImpl::visitCallInst(CallInst &CI) {
// Don't try to simplify calls without uses. It will not do anything useful,
// but will result in the following folds being skipped.
if (!CI.use_empty()) {
SmallVector<Value *, 4> Args;
SmallVector<Value *, 8> Args;
Copy link
Collaborator

@topperc topperc Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be rewritten as

SmallVector<Value *, 8> Args(CI.arg_begin(), CI.arg_end());

Copy link
Contributor Author

@kazutakahirata kazutakahirata Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you for bringing this up. It can actually be even shorter:

SmallVector<Value *, 8> Args(CI.args());

I'll post a follow-up PR.

Args.reserve(CI.arg_size());
for (Value *Op : CI.args())
Args.push_back(Op);
Expand Down