clang/lib/Lex/PPMacroExpansion.cpp: 2 * calls to obsolete function asctime

[dcb314]

Static analyser cppcheck says:

trunk/clang/lib/Lex/PPMacroExpansion.cpp:1728:16: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [asctimeCalled]

Source code is

 Result = asctime(TM);

trunk/clang/lib/Lex/PPMacroExpansion.cpp:1738:18: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [asctimeCalled]

Source code is

  Result = asctime(TM);

But "man asctime" says:

Marked obsolete in POSIX.1-2008 (recommending strftime(3)).

2008 is 16 years ago.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (dcb314)

Static analyser cppcheck says:

trunk/clang/lib/Lex/PPMacroExpansion.cpp:1728:16: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [asctimeCalled]

Source code is

 Result = asctime(TM);

trunk/clang/lib/Lex/PPMacroExpansion.cpp:1738:18: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [asctimeCalled]

Source code is

  Result = asctime(TM);

But "man asctime" says:

Marked obsolete in POSIX.1-2008 (recommending strftime(3)).

2008 is 16 years ago.

[shafik]

This does seem like a valid concern: https://wiki.sei.cmu.edu/confluence/display/c/MSC33-C.+Do+not+pass+invalid+data+to+the+asctime%28%29+function

Probably not high priority but perhaps a good first issue, I don't see any obvious traps switching to strftime here but maybe I am missing something CC @AaronBallman

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: None (dcb314)

Static analyser cppcheck says:

trunk/clang/lib/Lex/PPMacroExpansion.cpp:1728:16: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [asctimeCalled]

Source code is

 Result = asctime(TM);

trunk/clang/lib/Lex/PPMacroExpansion.cpp:1738:18: style: Obsolete function 'asctime' called. It is recommended to use 'strftime' instead. [asctimeCalled]

Source code is

  Result = asctime(TM);

But "man asctime" says:

Marked obsolete in POSIX.1-2008 (recommending strftime(3)).

2008 is 16 years ago.

[AaronBallman]

Agreed, this should be a straightforward refactoring, I'm not aware of any gotchas.

[yichi170]

I'm interested in working on this issue. How can I get assigned?

[yichi170]

Hi @AaronBallman, I have submitted the PR. Could you please help review it? Thank you!