[llvm-cov] Use-after-move of CoverageData

[nikic]

There are two places that move CoverageData inside a loop:

llvm-project/llvm/tools/llvm-cov/CodeCoverage.cpp

Lines 351 to 353 in 4310076

	View.addBranch(CurrentLine, std::move(ViewBranches),
	SourceCoverageView::create(SourceName, File, ViewOpts,
	std::move(CoverageInfo)));

llvm-project/llvm/tools/llvm-cov/CodeCoverage.cpp

Lines 377 to 379 in 4310076

	View.addMCDCRecord(CurrentLine, std::move(ViewMCDCRecords),
	SourceCoverageView::create(SourceName, File, ViewOpts,
	std::move(CoverageInfo)));

This looks incorrect to me, but I'm also unsure on what the right fix for this would be, as SourceCoverageView::create() accepts CoverageData by rvalue reference.

cc @evodius96 @MaskRay

[evodius96]

Ah, good catch. Should this created as a shared_ptr and then copied?

[nikic]

After taking a closer look, the views constructed here were never actually used. So we can fix this use-after-move by deleting some code :) #97734