Incompatible function declarations in CheckerDocumentation.cpp

[chaosrai]

I have identified the following incompatible function declarations when browsing the CheckerDocumentation.cpp, while the functions are accually used in Checker.h.

1. evalCall
   declared in CheckerDocumentation.cpp: bool evalCall(const CallExpr *CE, CheckerContext &C)
   used in Checker.h: bool evalCall(const CallEvent &Call, CheckerContext &C)

2. checkNewAllocator
   declared in CheckerDocumentation.cpp: void checkNewAllocator(const CXXNewExpr *NE, SVal Target, CheckerContext &)
   used in Checker.h: void checkNewAllocator(const CXXAllocatorCall &Call, CheckerContext &C)

And then there is a check point added in Checker.h but lost in the CheckerDocumentation.cpp:

1. ASTCodeBody
   void checkASTCodeBody(const Decl *D, AnalysisManager& mgr, BugReporter &BR)

These changes in Checker.h had better reflect in the CheckerDocumentation.cpp because newcomers like me will view it. This issue may belong to clang:static analyzer and documentation I guess.
Thanks :)

[llvmbot]

@llvm/issue-subscribers-clang-static-analyzer

Author: None (phyhac)

I have identified the following incompatible function declarations when browsing the [CheckerDocumentation.cpp](https://github.com/llvm/llvm-project/blob/main/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp), while the functions are accually used in [Checker.h](https://github.com/llvm/llvm-project/blob/main/clang/include/clang/StaticAnalyzer/Core/Checker.h).

1. evalCall
   declared in CheckerDocumentation.cpp: bool evalCall(const CallExpr *CE, CheckerContext &C)
   used in Checker.h: bool evalCall(const CallEvent &Call, CheckerContext &C)

2. checkNewAllocator
   declared in CheckerDocumentation.cpp: void checkNewAllocator(const CXXNewExpr *NE, SVal Target, CheckerContext &)
   used in Checker.h: void checkNewAllocator(const CXXAllocatorCall &Call, CheckerContext &C)

And then there is a check point added in Checker.h but lost in the CheckerDocumentation.cpp:

1. ASTCodeBody
   void checkASTCodeBody(const Decl *D, AnalysisManager& mgr, BugReporter &BR)

These changes in Checker.h had better reflect in the CheckerDocumentation.cpp because newcomers like me will view it. This issue may belong to clang:static analyzer and documentation I guess.
Thanks :)

[steakhal]

Ah! Indeed. Thanks for the report!

In PR #83973 I made sure that the your first two points never come up again.
Without reflection, unfortunately I have no way to automatically detect the third type of issue you raised.
So, I guess, we need to be diligent and add new checker callbacks here too.
I'll fix this issue tomorrow. Thanks again.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. In the comments of the issue, request for it to be assigned to you.
2. Fix the issue locally.
3. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
4. Create a Git commit.
5. Run git clang-format HEAD~1 to format your changes.
6. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Shichao Lai (phyhac)

I have identified the following incompatible function declarations when browsing the [CheckerDocumentation.cpp](https://github.com/llvm/llvm-project/blob/main/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp), while the functions are accually used in [Checker.h](https://github.com/llvm/llvm-project/blob/main/clang/include/clang/StaticAnalyzer/Core/Checker.h).

1. evalCall
   declared in CheckerDocumentation.cpp: bool evalCall(const CallExpr *CE, CheckerContext &C)
   used in Checker.h: bool evalCall(const CallEvent &Call, CheckerContext &C)

2. checkNewAllocator
   declared in CheckerDocumentation.cpp: void checkNewAllocator(const CXXNewExpr *NE, SVal Target, CheckerContext &)
   used in Checker.h: void checkNewAllocator(const CXXAllocatorCall &Call, CheckerContext &C)

And then there is a check point added in Checker.h but lost in the CheckerDocumentation.cpp:

1. ASTCodeBody
   void checkASTCodeBody(const Decl *D, AnalysisManager& mgr, BugReporter &BR)

These changes in Checker.h had better reflect in the CheckerDocumentation.cpp because newcomers like me will view it. This issue may belong to clang:static analyzer and documentation I guess.
Thanks :)