clang-tidy x86 crashes when modernize-use-nullptr check is enabled.

[kylereedmsft]

"C:\Program Files\Microsoft Visual Studio\2022\main\VC\Tools\Llvm\bin\clang-tidy.exe" repro.cpp --checks="modernize-use-nullptr"
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace.
Stack dump:
0. Program arguments: "C:\Program Files\Microsoft Visual Studio\2022\main\VC\Tools\Llvm\bin\clang-tidy.exe" repro.cpp --checks=modernize-use-nullptr
#0 0x0167f750 C:\Program Files\Microsoft Visual Studio\2022\main\VC\Tools\Llvm\bin\clang-tidy.exe 0xd3f750
0x0167F750 (0x00000069 0x00000104 0x04730CD0 0x0438E038)

LLVM (http://llvm.org/):
LLVM version 13.0.0
Optimized build.
Default target: i686-pc-windows-msvc
Host CPU: skylake

Host OS: x64 Windows 11.

I'm using the toolset that ships with Visual Studio, but this also repros with the official release.
repro.cpp is an empty file, but it will repro on any file.
This issue does not repro with the x64 version of the tool.
Both modernize-use-nullptr and hicpp-use-nullptr will cause the crash.

[llvmbot]

@llvm/issue-subscribers-clang-tidy

[JonasToth]

Could you please provide the reproducer here or did I overlook something?

If it contains sensitive code, you can try creduce. The reproducer should be self-contained. You can preprocess the file with the -E option of clang (i have no clue how to do it with visual studio).

[kylereedmsft]

It repros with an empty file. It seems to be a problem if the check is even enabled.

[JonasToth]

thanks. that is weird, as there the normal test-suite does not trigger this issue (and they have tests), neither on windows nor linux nor any other of the platforms.

I do not have windows, so i can not reproduce it. I assume this is the only check that triggers the issue, right?

Did you check different versions of LLVM? This check should be present and not be touched since a view releases. Does it happen there, too?

[kylereedmsft]

Yes, it's only this check. I started with * and then narrowed it down from there.
It only reproduces when using the x86 build of the tools on x64 Windows.
I just tried again with 13.0.1 and it's still failing there.

[kylereedmsft]

It does not repro in 11.0.0

[njames93]

Yes, it's only this check. I started with * and then narrowed it down from there.
It only reproduces when using the x86 build of the tools on x64 Windows.
I just tried again with 13.0.1 and it's still failing there.

Unrelated but that pain should hopefully be alleviated in clang-tidy-15 😃

[fsandhei]

@EugeneZelenko, @njames93, we have run into the same issue when running clang-tidy on x86-windows. It fails with 14.0.6 and 15.0.5 both.

Is there any update from you guys on if this would be fixed at some point?

Luckily we can get around this by disabling modernize-use-nullptr, so it's not the worst thing

[njames93]

Can you please provide a stack trace of the crash when running clang-tidy-15

[fsandhei]

Can you please provide a stack trace of the crash when running clang-tidy-15

Attaching an output of a reproduced case. main.cpp is completely empty.

c:\dev\github\NordicPlayground\nrf-device-lib>clang-tidy --version
LLVM (http://llvm.org/):
  LLVM version 15.0.5
  Optimized build.
  Default target: i686-pc-windows-msvc
  Host CPU: skylake

c:\dev\github\NordicPlayground\nrf-device-lib>clang-tidy main.cpp --checks=modernize-use-nullptr
Error while trying to load a compilation database:
Could not auto-detect compilation database for file "main.cpp"
No compilation database found in c:\dev\github\NordicPlayground\nrf-device-lib or any parent directory
fixed-compilation-database: Error while opening fixed database: no such file or directory
json-compilation-database: Error while opening JSON database: no such file or directory
Running without flags.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: clang-tidy main.cpp --checks=modernize-use-nullptr
Exception Code: 0xC0000005
#0 0x01769780 C:\Program Files (x86)\LLVM\bin\clang-tidy.exe 0x7c9780
0x01769780, C:\Program Files (x86)\LLVM\bin\clang-tidy.exe(0x0000000000FA0000) + 0x7C9780 byte(s)

[njames93]

Is that the whole stack trace?