unused variable: Target/ARM/ARMConstantIslandPass.cpp:333

[ggreif]

Bugzilla Link	44808
Resolution	FIXED
Resolved on	Mar 07, 2020 16:50
Version	10.0
OS	All
Blocks	#43900
CC	@zmodem,@smithp35

Extended Description

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:333:17: warning: unused variable 'BBInfo' [-Wunused-variable]
BBInfoVector &BBInfo = BBUtils->getBBInfo();
^
Should be an easy fix.

[ggreif]

Similarly

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/AMDGPU/SIPeepholeSDWA.cpp:247:21: warning: unused function 'operator<<' [-Wunused-function]
static raw_ostream& operator<<(raw_ostream &OS, const SDWAOperand &Operand) {
^

[zmodem]

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/ARM/
ARMConstantIslandPass.cpp:333:17: warning: unused variable 'BBInfo'
[-Wunused-variable]
BBInfoVector &BBInfo = BBUtils->getBBInfo();
^
Should be an easy fix.

Committed ea9850b
I'll cherry-pick that once it's been a master a little while.

Similarly

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/AMDGPU/SIPeepholeSDWA.
cpp:247:21: warning: unused function 'operator<<' [-Wunused-function]
static raw_ostream& operator<<(raw_ostream &OS, const SDWAOperand &Operand) {
^

Hmm, I don't get any warning about this. Which compiler and version are you using?

[ggreif]

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/ARM/
ARMConstantIslandPass.cpp:333:17: warning: unused variable 'BBInfo'
[-Wunused-variable]
BBInfoVector &BBInfo = BBUtils->getBBInfo();
^
Should be an easy fix.

Committed ea9850b
I'll cherry-pick that once it's been a master a little while.

Similarly

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/AMDGPU/SIPeepholeSDWA.
cpp:247:21: warning: unused function 'operator<<' [-Wunused-function]
static raw_ostream& operator<<(raw_ostream &OS, const SDWAOperand &Operand) {
^

Hmm, I don't get any warning about this. Which compiler and version are you
using?

This is what cmake says:

-- The C compiler identification is Clang 7.1.0
-- The CXX compiler identification is Clang 7.1.0
-- The ASM compiler identification is Clang
-- Found assembler: /nix/store/5x6gxvagh2y8svbxqzgwrjcanw4nj1yf-clang-wrapper-7.1.0/bin/clang
-- Check for working C compiler: /nix/store/5x6gxvagh2y8svbxqzgwrjcanw4nj1yf-clang-wrapper-7.1.0/bin/clang
-- Check for working C compiler: /nix/store/5x6gxvagh2y8svbxqzgwrjcanw4nj1yf-clang-wrapper-7.1.0/bin/clang -- works

It is the go-to compiler for Darwin in Nixpkgs.

[zmodem]

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/ARM/
ARMConstantIslandPass.cpp:333:17: warning: unused variable 'BBInfo'
[-Wunused-variable]
BBInfoVector &BBInfo = BBUtils->getBBInfo();
^
Should be an easy fix.

Committed ea9850b
I'll cherry-pick that once it's been a master a little while.

Pushed as 2804f35

Similarly

/tmp/nix-build-llvm-10.0.0rc1.drv-0/llvm/lib/Target/AMDGPU/SIPeepholeSDWA.
cpp:247:21: warning: unused function 'operator<<' [-Wunused-function]
static raw_ostream& operator<<(raw_ostream &OS, const SDWAOperand &Operand) {
^

Hmm, I don't get any warning about this. Which compiler and version are you
using?

Oh I see, it's used in code inside a LLVM_DEBUG macro.

Should be fixed with a19de32. I'll merge that after it's been in trunk a little while.

[zmodem]

Should be fixed with a19de32. I'll merge
that after it's been in trunk a little while.

Pushed to 10.x as 5f76fcc

[ggreif]

Both warnings are gone. Thanks!