LLDB 10.x (and current master) fails to build with GCC 5.4

[mstorsjo]

Bugzilla Link	44791
Resolution	FIXED
Resolved on	Feb 06, 2020 01:56
Version	10.0
OS	All
Blocks	#43900
CC	@adrian-prantl,@zmodem,@JDevlieghere,@labath

Extended Description

Building the current master with GCC 5.4 (on Ubuntu 16.04) fails like this:

../tools/lldb/source/DataFormatters/LanguageCategory.cpp:71:68: error: specialization of 'template auto& lldb_private::LanguageCategory::GetHardcodedFinder()' in different namespace [-fpermissive]
auto &LanguageCategory::GetHardcodedFinderlldb::TypeFormatImplSP() {
^
In file included from ../tools/lldb/source/DataFormatters/LanguageCategory.cpp:9:0:
../tools/lldb/include/lldb/DataFormatters/LanguageCategory.h:52:9: error: from definition of 'template auto& lldb_private::LanguageCategory::GetHardcodedFinder()' [-fpermissive]
auto &GetHardcodedFinder();
^
../tools/lldb/source/DataFormatters/LanguageCategory.cpp:76:69: error: specialization of 'template auto& lldb_private::LanguageCategory::GetHardcodedFinder()' in different namespace [-fpermissive]
auto &LanguageCategory::GetHardcodedFinderlldb::TypeSummaryImplSP() {
^
In file included from ../tools/lldb/source/DataFormatters/LanguageCategory.cpp:9:0:
../tools/lldb/include/lldb/DataFormatters/LanguageCategory.h:52:9: error: from definition of 'template auto& lldb_private::LanguageCategory::GetHardcodedFinder()' [-fpermissive]
auto &GetHardcodedFinder();
^
../tools/lldb/source/DataFormatters/LanguageCategory.cpp:81:71: error: specialization of 'template auto& lldb_private::LanguageCategory::GetHardcodedFinder()' in different namespace [-fpermissive]
auto &LanguageCategory::GetHardcodedFinderlldb::SyntheticChildrenSP() {
^
In file included from ../tools/lldb/source/DataFormatters/LanguageCategory.cpp:9:0:
../tools/lldb/include/lldb/DataFormatters/LanguageCategory.h:52:9: error: from definition of 'template auto& lldb_private::LanguageCategory::GetHardcodedFinder()' [-fpermissive]
auto &GetHardcodedFinder();
^

[labath]

It sounds like the fix should be pretty straight-forward -- wrap the relevant specializations in namespace lldb_private {}. (Though I don't really understand why is that necessary.)

Since you seem to have gcc 5.4 around to test this, would it be too much of a trouble to ask you to create a patch?

[zmodem]

Martin fixed this in https://reviews.llvm.org/D74084

Cherry-picked to 10.x as 22633f8