llvm-config --system-libs reports absolute path for zlib without rpath

[andrewrk]

Bugzilla Link	44780
Resolution	FIXED
Resolved on	Mar 03, 2020 06:22
Version	10.0
OS	Linux
Blocks	#43900
CC	@llvm-beanz,@compnerd,@zmodem,@petrhosek,@smeenai,@tstellar

Extended Description

Similar to #43524

9.0.1 behavior:
$ llvm-config --system-libs
-lz -lrt -ldl -lpthread -lm

10.0.0rc1 behavior:
$ llvm-config --system-libs
/nix/store/a3q9zl42d0hmgwmgzwkxi5qd88055fh8-zlib-1.2.11/lib/libz.so -lrt -ldl -lpthread -lm

This ends up going onto the linker line for LLD, producing a binary like this:

[nix-shell:~/tmp/zig/build-llvm10-release]$ ldd /home/andy/tmp/zig/zig-cache/o/39NGPp09af-0J9UEs7IabCuJBpR-9JHgtGfNslZiZIiA6j-mQbVfX1mISEjZIn7Y/test
linux-vdso.so.1 (0x00007ffd68593000)
libz.so.1 => not found
libc.so.6 => /nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib/libc.so.6 (0x00007f873f1e2000)
libm.so.6 => /nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib/libm.so.6 (0x00007f873f04c000)
libpthread.so.0 => /nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib/libpthread.so.0 (0x00007f873f02b000)
libdl.so.2 => /nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib/libdl.so.2 (0x00007f873f026000)
librt.so.1 => /nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib/librt.so.1 (0x00007f873f01c000)
/nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib/ld-linux-x86-64.so.2 => /nix/store/aag9d1y4wcddzzrpfmfp9lcmc7skd7jk-glibc-2.27/lib64/ld-linux-x86-64.so.2 (0x00007f873f39a000)

(notice the "libz.so.1 => not found")

This issue would be resolved if --system-libs also reported the rpath for libz.so, or if it reported -lz like it did in llvm 9.

I believe the related patch is https://reviews.llvm.org/D70764.

[zmodem]

I believe the related patch is https://reviews.llvm.org/D70764.

Saleem, can you take a look at this?

[smeenai]

https://reviews.llvm.org/D74176 potentially fixes this.

[zmodem]

I pushed the following three to 10.x, so it should be fixed now:

D74106 50a6d3a "[CMake] Use PUBLIC link mode for static libraries"
D74176 2181bf4 "[CMake] Link against ZLIB::ZLIB"
1079c68 "Attempt to fix ZLIB CMake logic on Windows"

This will be one of the last things to go into the release, so please let me know as soon as possible if there are any follow-ups or if this caused any problems.

[andrewrk]

Confirmed, fixed in latest release/10.x branch:

(before)

andy@ark ~> ~/local/llvm10-release/bin/llvm-config --system-libs
/nix/store/a3q9zl42d0hmgwmgzwkxi5qd88055fh8-zlib-1.2.11/lib/libz.so -lrt -ldl -lpthread -lm

(after)

andy@ark ~> ~/local/llvm10-release/bin/llvm-config --system-libs
-lrt -ldl -lpthread -lm -lz

Thanks!

[andrewrk]

I'm sorry, I spoke too soon. I'm now unable to build LLD from source in the release/10.x branch:

[nix-shell:~/Downloads/llvm-project-10/lld/build-release]$ make -j8 install
-- Linker detection: GNU ld
/nix/store/x5m45fcnky99r0k41kmdwmjb7zw5k4z4-binutils-2.31.1/bin/ar: creating t.a
-- Building with -fPIC
-- LLD version: 10.0.0
-- Configuring done
CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:789 (add_executable):
Target "lld" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:37 (add_llvm_executable)
cmake/modules/AddLLD.cmake:46 (add_lld_executable)
tools/lld/CMakeLists.txt:5 (add_lld_tool)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:789 (add_executable):
Target "lld" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:37 (add_llvm_executable)
cmake/modules/AddLLD.cmake:46 (add_lld_executable)
tools/lld/CMakeLists.txt:5 (add_lld_tool)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldCommon" links to target "ZLIB::ZLIB" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
Common/CMakeLists.txt:30 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldCore" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
lib/Core/CMakeLists.txt:5 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldDriver" links to target "ZLIB::ZLIB" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
lib/Driver/CMakeLists.txt:5 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldReaderWriter" links to target "ZLIB::ZLIB" but the target was
not found. Perhaps a find_package() call is missing for an IMPORTED
target, or an ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
lib/ReaderWriter/CMakeLists.txt:8 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldMachO" links to target "ZLIB::ZLIB" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
lib/ReaderWriter/MachO/CMakeLists.txt:1 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldYAML" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
lib/ReaderWriter/YAML/CMakeLists.txt:1 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldCOFF" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
COFF/CMakeLists.txt:9 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldELF" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
ELF/CMakeLists.txt:9 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldMinGW" links to target "ZLIB::ZLIB" but the target was not
found. Perhaps a find_package() call is missing for an IMPORTED target, or
an ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
MinGW/CMakeLists.txt:9 (add_lld_library)

CMake Error at /home/andy/local/llvm10-release/lib/cmake/llvm/AddLLVM.cmake:493 (add_library):
Target "lldWasm" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddLLD.cmake:10 (llvm_add_library)
wasm/CMakeLists.txt:9 (add_lld_library)

-- Generating done
CMake Generate step failed. Build files cannot be regenerated correctly.
make: *** [Makefile:448: cmake_check_build_system] Error 1

[andrewrk]

Same problem with clang

[zmodem]

Thanks for catching that!

Notes on reproducing:

in llvm.monorepo/build.llvm:

$ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install_prefix ../llvm
$ ninja && ninja install

in build.clang: (using the legacy LLVM_CONFIG variable)

$ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_CONFIG=/tmp/install_prefix/bin/llvm-config ../clang

CMake Error at /tmp/install_prefix/lib/cmake/llvm/AddLLVM.cmake:789 (add_executable):
Target "clang" links to target "ZLIB::ZLIB" but the target was not found.
Perhaps a find_package() call is missing for an IMPORTED target, or an
ALIAS target is missing?
Call Stack (most recent call first):
cmake/modules/AddClang.cmake:140 (add_llvm_executable)
cmake/modules/AddClang.cmake:150 (add_clang_executable)
tools/driver/CMakeLists.txt:31 (add_clang_tool)

in build.clang: (using the LLVM_DIR variable)

$ cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_DIR=/tmp/install_prefix/lib/cmake/llvm ../clang

same error.

[zmodem]

I've pulled out the zlib related cmake changes in 916be8f on master, and will merge that to 10.x after it's baked a little bit.

[zmodem]

I've pulled out the zlib related cmake changes in
916be8f on master, and will merge that to
10.x after it's baked a little bit.

Pushed to 10.x as 5f9211b.

[andrewrk]

Thanks- I can confirm that there are no longer any regressions from 9.0.1 related to this.