Skip to content

Disable mmap for source files that change under us #44055

@sam-mccall

Description

@sam-mccall
Bugzilla Link 44710
Resolution FIXED
Resolved on Jan 29, 2020 13:14
Version unspecified
OS Linux
Blocks #43900
CC @zmodem

Extended Description

b500c49 turns off mmap for source files in clangd. SourceManager has a habit of crashing when the data changes from under it, most often when switching git branches.

This is a fairly safe change and eliminates a common crasher, and we've been shipping this on windows for a while already. We should merge it into 10.x

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugzillaIssues migrated from bugzillaclangd

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions