libclang-cpp.so requires linking with --as-needed when clang is built with -DBUILD_SHARED_LIBS=ON

[tstellar]

Bugzilla Link	44612
Resolution	FIXED
Resolved on	Feb 10, 2020 04:36
Version	10.0
OS	Linux
Blocks	#43900
CC	@zmodem,@zygoloid

Extended Description

I have submitted a patch for this:

https://reviews.llvm.org/D68520

I would like to try to get this fix into 10.0, because this bug is preventing upstream projects from using libclang-cpp.so.

[zmodem]

Cherry-picked to 10.x in 3e429b6

[tstellar]

I just had to revert this commit in trunk. It uses a cmake 3.6 feature, and llvm only requires 3.4.3 or newer.

[zmodem]

Thanks, I've cherry-picked the revert in ba92233

[tstellar]

This has been fixed again in trunk: ebcf25e

[zmodem]

This has been fixed again in trunk: ebcf25e

Pushed that to 10.x as e2c0c70

Please let me know if there are any follow-ups.