Segfault due to incorrect initialization order in compiler extension

[serge-sans-paille]

Bugzilla Link	44568
Resolution	FIXED
Resolved on	Feb 27, 2020 02:10
Version	trunk
OS	Linux
Blocks	#43900
CC	@echristo,@zmodem
Fixed by commit(s)	ab2300b 52c1d20

Extended Description

The new compiler extension mecanism that landed in 24ab9b5 and 346de9b can cause segmentation fault upon llvm::terminate due to invalid initialization order of ManagedStatic.

The bug is fixed by https://reviews.llvm.org/D72493.

[serge-sans-paille]

https://reviews.llvm.org/D72493 is being obsoleted by https://reviews.llvm.org/D71959

[zmodem]

https://reviews.llvm.org/D72493 is being obsoleted by
https://reviews.llvm.org/D71959

D71959 was cherry-picked to 10.x as 52c1d20

But it sounds like there are still problems: https://reviews.llvm.org/D71959#1860286

From what I understand the patch that was reverted wasn't on 10.x, but maybe there is still an underlying problem?

[zmodem]

Does anyone know what the status is here?

[zmodem]

Does anyone know what the status is here?

sguelton: ping?

[serge-sans-paille]

@​hans: this want out of my radar. I'll try to reproduce and fix.

[serge-sans-paille]

@​hans looks like the build is now ok, I ran a build with same cmake config on OSX and it went nice: https://github.com/serge-sans-paille/llvm-project/pull/13/checks

I removed the REQUIRES: constraint on the test, and didn't receive any failing error yet, let's wait a day or two to confirm.

[serge-sans-paille]

@​hans: no error spotted by the build slaves, no feedback from other users, I think we can consider this one closed.

[zmodem]

Okay, closing.