FindExplicitReferences test fails with EXPENSIVE_CHECKS

[aemerson]

Bugzilla Link	44564
Resolution	FIXED
Resolved on	Feb 19, 2020 05:12
Version	unspecified
OS	MacOS X
Blocks	#43900
CC	@zmodem,@kadircet,@RKSimon,@HighCommander4
Fixed by commit(s)	d54d71b

Extended Description

When running with EXPENSIVE_TESTS the FindExplicitReferencesTest in the clangd unit tests fails, somewhat non-deterministically.

This is likely due to using some data structure with non-deterministic iteration order, as STLExtras will shuffle elements with EXPENSIVE_TESTS.

This is showing up in the greendragon bot: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/15318/

[kadircet]

Should be fixed after d54d71b

[RKSimon]

Amara + Kadir - Should this be back ported to the 10.0 release?

[aemerson]

I don't know anything about clangd, will defer to Kadir for that.

[kadircet]

Yes, I'll add it to the release blocker PR.

In the meantime could you verify the fix has worked Amara ?

[RKSimon]

Reopening until Amara has confirmed the fix and its been merged into 10.0

[RKSimon]

Amara - please can you confirm d54d71b fixed the issue so it can be merged into 10.0?

[zmodem]

Pushed Kadir's fix to 10.x as d5f8656