Please backport r369310 to 9.x

[llvmbot]

Bugzilla Link	43196
Resolution	FIXED
Resolved on	Sep 05, 2019 02:51
Version	9.0
OS	Linux
Blocks	#41819
Reporter	LLVM Bugzilla Contributor
CC	@zmodem,@lhames

Extended Description

While the commit in question is marked as 'NFC', without it the following tests hang for me on NetBSD:

LLVM :: ExecutionEngine/MCJIT/eh-lg-pic.ll
LLVM :: ExecutionEngine/MCJIT/eh.ll
LLVM :: ExecutionEngine/MCJIT/multi-module-eh-a.ll
LLVM :: ExecutionEngine/OrcMCJIT/eh-lg-pic.ll
LLVM :: ExecutionEngine/OrcMCJIT/eh.ll
LLVM :: ExecutionEngine/OrcMCJIT/multi-module-eh-a.ll

To be honest, I don't know how it is relevant. It is possible that the linking is necessary for reasons other than those listed in the commit message.

commit 949113e632cf531019f121a27c9725abc65daa56
Author: Hubert Tong hubert.reinterpretcast@gmail.com
Date: Mon Aug 19 23:12:48 2019 +0000

[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC

Summary:
rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on LLVMPasses.                                                                      
In particular, symbols defined in LLVMPasses that are referenced by the                                                                       
destructor of `PassBuilder` are now referenced by LLVMOrcJIT through
`Speculation.cpp.o`.

We believe that referencing symbols defined in LLVMPasses in the
destructor of `PassBuilder` is valid, and that adding to the set of such                                                                      
symbols is legitimate. To support such cases, this patch adds LLVMPasses                                                                      
to the set of libraries being linked when linking in LLVMOrcJIT causes                                                                        
such symbols from LLVMPasses to be referenced.

Reviewers: Whitney, anhtuyen, pree-jackie

Reviewed By: pree-jackie

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66441

llvm-svn: 369310

[zmodem]

I'm not familiar with this stuff. Lang, does this make sense to you?

[lhames]

I have no idea why adding this dependency would affect this. Adding the dependency was the right thing to do though, so if it fixes these tests I would be inclined to back-port it.

[zmodem]

Merged to release_90 in r371042.