[analyzer] Analyzer reports duplicate warnings to console when using `-analyzer-output=sarif-html`

[dbartol]

To repro:

int foo(int* p) {
    if (p != nullptr) {
        return 0;
    } else {
        return *p;
    }
}

clang --analyze -Xclang -analyzer-output=sarif-html

Actual result:

foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
3 warnings generated.

Expected result:

foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
1 warning generated.

[dbartol]

This is because the code to create the diagnostic consumers for sarif-html just calls to code for sarif and html in sequence, each of which creates its own minimal text consumer as well. Then the serif-html code itself creates a third for good measure 😏.

I'll put up a PR shortly.

[llvmbot]

@llvm/issue-subscribers-clang-static-analyzer

Author: Dave Bartolomeo (dbartol)

To repro: ```c++ int foo(int* p) { if (p != nullptr) { return 0; } else { return *p; } } ``` ```bash clang --analyze -Xclang -analyzer-output=sarif-html ```

Actual result:

foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
3 warnings generated.

Expected result:

foo.cpp:5:16: warning: Dereference of null pointer (loaded from variable 'p') [core.NullDereference]
    5 |         return *p;
      |                ^~
1 warning generated.