Assertion hit in `ConvertUTFWrapper.cpp` on Windows

[fabianfett]

Assertion failed: Out.empty(), file C:\Users\swift-ci\jenkins\workspace\swift-6.1-windows-toolchain\llvm-project\llvm\lib\Support\ConvertUTFWrapper.cpp, line 85
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.	Program arguments: C:\\Users\\fat\\AppData\\Local\\Programs\\Swift\\Toolchains\\6.1.2+Asserts\\usr\\bin\\lldb-dap.exe
Exception Code: 0x80000003
 #0 0x00007ff641d66565 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x66565)
 #1 0x00007ff91ca51989 (C:\WINDOWS\System32\ucrtbase.dll+0xc1989)
 #2 0x00007ff91ca34ab1 (C:\WINDOWS\System32\ucrtbase.dll+0xa4ab1)
 #3 0x00007ff91ca52986 (C:\WINDOWS\System32\ucrtbase.dll+0xc2986)
 #4 0x00007ff91ca52b61 (C:\WINDOWS\System32\ucrtbase.dll+0xc2b61)
 #5 0x00007ff89ced44b0 PyInit__lldb (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\liblldb.dll+0xc844b0)
 #6 0x00007ff89cc33141 PyInit__lldb (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\liblldb.dll+0x9e3141)
 #7 0x00007ff89c4c2902 lldb::SBThread::GetName(void) const (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\liblldb.dll+0x272902)
 #8 0x00007ff641d32fda (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x32fda)
 #9 0x00007ff641d2285e (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x2285e)
#10 0x00007ff641d45b0c (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x45b0c)
#11 0x00007ff641d46048 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x46048)
#12 0x00007ff641d24c40 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x24c40)
#13 0x00007ff641d7ab10 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x7ab10)
#14 0x00007ff91e39e8d7 (C:\WINDOWS\System32\KERNEL32.DLL+0x2e8d7)
#15 0x00007ff91ef5c34c (C:\WINDOWS\SYSTEM32\ntdll.dll+0x3c34c)

Im running into this assertion using a Swift 6.1 toolchain on Windows 11.

[llvmbot]

@llvm/issue-subscribers-lldb

Author: Fabian Fett (fabianfett)

``` Assertion failed: Out.empty(), file C:\Users\swift-ci\jenkins\workspace\swift-6.1-windows-toolchain\llvm-project\llvm\lib\Support\ConvertUTFWrapper.cpp, line 85 PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace. Stack dump: 0. Program arguments: C:\\Users\\fat\\AppData\\Local\\Programs\\Swift\\Toolchains\\6.1.2+Asserts\\usr\\bin\\lldb-dap.exe Exception Code: 0x80000003 #0 0x00007ff641d66565 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x66565) #1 0x00007ff91ca51989 (C:\WINDOWS\System32\ucrtbase.dll+0xc1989) #2 0x00007ff91ca34ab1 (C:\WINDOWS\System32\ucrtbase.dll+0xa4ab1) #3 0x00007ff91ca52986 (C:\WINDOWS\System32\ucrtbase.dll+0xc2986) #4 0x00007ff91ca52b61 (C:\WINDOWS\System32\ucrtbase.dll+0xc2b61) #5 0x00007ff89ced44b0 PyInit__lldb (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\liblldb.dll+0xc844b0) #6 0x00007ff89cc33141 PyInit__lldb (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\liblldb.dll+0x9e3141) #7 0x00007ff89c4c2902 lldb::SBThread::GetName(void) const (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\liblldb.dll+0x272902) #8 0x00007ff641d32fda (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x32fda) #9 0x00007ff641d2285e (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x2285e) #10 0x00007ff641d45b0c (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x45b0c) #11 0x00007ff641d46048 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x46048) #12 0x00007ff641d24c40 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x24c40) #13 0x00007ff641d7ab10 (C:\Users\fat\AppData\Local\Programs\Swift\Toolchains\6.1.2+Asserts\usr\bin\lldb-dap.exe+0x7ab10) #14 0x00007ff91e39e8d7 (C:\WINDOWS\System32\KERNEL32.DLL+0x2e8d7) #15 0x00007ff91ef5c34c (C:\WINDOWS\SYSTEM32\ntdll.dll+0x3c34c) ```

Im running into this assertion using a Swift 6.1 toolchain on Windows 11.

[JDevlieghere]

This was fixed by #134150

[DavidSpickett]

The code it was fixing, is it on the 21 branch, do we need to cherry pick the fix?

[JDevlieghere]

The code it was fixing, is it on the 21 branch, do we need to cherry pick the fix?

Yup, the upstream change is #134150. I linked the Swift one since @fabianfett mentioned the Swift release (which also means this issue should have been in swiftlang/llvm-project)

[DavidSpickett]

Oh yeah that was ages ago, thanks for checking.