Clang-format 19 regression from 18

[sgh]

Clang-format 19 generates this :

struct DLL_PUBLIC SomeClas{SomeClass(){}};

however if I remove DLL_PUBLIC I get this:

struct SomeClas {
SomeClass() {}
};

This is my clang-format

---

Language: Cpp

BasedOnStyle: Google

AccessModifierOffset: -4
AlignAfterOpenBracket: Align
AlignArrayOfStructures: Left
AlignConsecutiveAssignments:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: true
AlignConsecutiveBitFields:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: false
AlignConsecutiveDeclarations:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: false
AlignConsecutiveMacros:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: false
AlignEscapedNewlines: Left
AlignOperands: Align
AlignTrailingComments:
Kind: Always
OverEmptyLines: 0
AllowAllArgumentsOnNextLine: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortBlocksOnASingleLine: Empty
AllowShortCaseLabelsOnASingleLine: false
AllowShortEnumsOnASingleLine: true
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: Never
AllowShortLambdasOnASingleLine: All
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: Yes
AttributeMacros:

• __capability
  BinPackArguments: true
  BinPackParameters: true
  BitFieldColonSpacing: Both
  BraceWrapping:
  AfterCaseLabel: false
  AfterClass: false
  AfterControlStatement: Never
  AfterEnum: false
  AfterExternBlock: false
  AfterFunction: false
  AfterNamespace: false
  AfterObjCDeclaration: false
  AfterStruct: false
  AfterUnion: false
  BeforeCatch: false
  BeforeElse: false
  BeforeLambdaBody: false
  BeforeWhile: false
  IndentBraces: false
  SplitEmptyFunction: true
  SplitEmptyRecord: true
  SplitEmptyNamespace: true
  BreakAfterAttributes: Never
  BreakAfterJavaFieldAnnotations: false
  BreakArrays: true
  BreakBeforeBinaryOperators: None
  BreakBeforeConceptDeclarations: Always
  BreakBeforeBraces: Attach
  BreakBeforeInlineASMColon: OnlyMultiline
  BreakBeforeTernaryOperators: true
  BreakConstructorInitializers: BeforeColon
  BreakInheritanceList: BeforeColon
  BreakStringLiterals: true
  ColumnLimit: 120
  CommentPragmas: '^ IWYU pragma:'
  CompactNamespaces: false
  ConstructorInitializerIndentWidth: 4
  ContinuationIndentWidth: 4
  Cpp11BracedListStyle: true
  DerivePointerAlignment: false
  DisableFormat: false
  EmptyLineAfterAccessModifier: Never
  EmptyLineBeforeAccessModifier: LogicalBlock
  ExperimentalAutoDetectBinPacking: false
  FixNamespaceComments: true
  ForEachMacros:
• foreach
• Q_FOREACH
• BOOST_FOREACH
  IfMacros:
• KJ_IF_MAYBE
  IncludeBlocks: Regroup
  IncludeCategories:
• Regex: '^<ext/.*.h>'
  Priority: 2
  SortPriority: 0
  CaseSensitive: false
• Regex: '^<.*.h>'
  Priority: 1
  SortPriority: 0
  CaseSensitive: false
• Regex: '^<.*'
  Priority: 2
  SortPriority: 0
  CaseSensitive: false
• Regex: '.*'
  Priority: 3
  SortPriority: 0
  CaseSensitive: false
  IncludeIsMainRegex: '(-_)?$'
  IncludeIsMainSourceRegex: ''
  IndentAccessModifiers: false
  IndentCaseBlocks: false
  IndentCaseLabels: true
  IndentExternBlock: AfterExternBlock
  IndentGotoLabels: true
  IndentPPDirectives: None
  IndentRequiresClause: true
  IndentWidth: 4
  IndentWrappedFunctionNames: false
  InsertBraces: false
  InsertNewlineAtEOF: false
  InsertTrailingCommas: None
  IntegerLiteralSeparator:
  Binary: 0
  BinaryMinDigits: 0
  Decimal: 0
  DecimalMinDigits: 0
  Hex: 0
  HexMinDigits: 0
  JavaScriptQuotes: Leave
  JavaScriptWrapImports: true
  KeepEmptyLinesAtTheStartOfBlocks: false
  LambdaBodyIndentation: Signature
  LineEnding: DeriveLF
  MacroBlockBegin: ''
  MacroBlockEnd: ''
  MaxEmptyLinesToKeep: 1
  NamespaceIndentation: None
  ObjCBinPackProtocolList: Never
  ObjCBlockIndentWidth: 2
  ObjCBreakBeforeNestedBlockParam: true
  ObjCSpaceAfterProperty: false
  ObjCSpaceBeforeProtocolList: true
  PackConstructorInitializers: NextLine
  PenaltyBreakAssignment: 2
  PenaltyBreakBeforeFirstCallParameter: 1
  PenaltyBreakComment: 300
  PenaltyBreakFirstLessLess: 120
  PenaltyBreakOpenParenthesis: 0
  PenaltyBreakString: 1000
  PenaltyBreakTemplateDeclaration: 10
  PenaltyExcessCharacter: 1000000
  PenaltyIndentedWhitespace: 0
  PenaltyReturnTypeOnItsOwnLine: 200
  PointerAlignment: Left
  PPIndentWidth: -1
  QualifierAlignment: Leave
  RawStringFormats:
• Language: Cpp
  Delimiters:
  • cc
  • CC
  • cpp
  • Cpp
  • CPP
  • 'c++'
  • 'C++'
    CanonicalDelimiter: ''
    BasedOnStyle: google
• Language: TextProto
  Delimiters:
  • pb
  • PB
  • proto
  • PROTO
    EnclosingFunctions:
  • EqualsProto
  • EquivToProto
  • PARSE_PARTIAL_TEXT_PROTO
  • PARSE_TEST_PROTO
  • PARSE_TEXT_PROTO
  • ParseTextOrDie
  • ParseTextProtoOrDie
  • ParseTestProto
  • ParsePartialTestProto
    CanonicalDelimiter: pb
    BasedOnStyle: google
    ReferenceAlignment: Pointer
    ReflowComments: false
    RemoveBracesLLVM: false
    RemoveSemicolon: false
    RequiresClausePosition: OwnLine
    RequiresExpressionIndentation: OuterScope
    SeparateDefinitionBlocks: Leave
    ShortNamespaceLines: 1
    SortIncludes: CaseSensitive
    SortJavaStaticImport: Before
    SortUsingDeclarations: LexicographicNumeric
    SpaceAfterCStyleCast: false
    SpaceAfterLogicalNot: false
    SpaceAfterTemplateKeyword: true
    SpaceAroundPointerQualifiers: Default
    SpaceBeforeAssignmentOperators: true
    SpaceBeforeCaseColon: false
    SpaceBeforeCpp11BracedList: false
    SpaceBeforeCtorInitializerColon: true
    SpaceBeforeInheritanceColon: true
    SpaceBeforeParens: ControlStatements
    SpaceBeforeParensOptions:
    AfterControlStatements: true
    AfterForeachMacros: true
    AfterFunctionDefinitionName: false
    AfterFunctionDeclarationName: false
    AfterIfMacros: true
    AfterOverloadedOperator: false
    AfterRequiresInClause: false
    AfterRequiresInExpression: false
    BeforeNonEmptyParentheses: false
    SpaceBeforeRangeBasedForLoopColon: true
    SpaceBeforeSquareBrackets: false
    SpaceInEmptyBlock: false
    SpaceInEmptyParentheses: false
    SpacesBeforeTrailingComments: 2
    SpacesInAngles: Never
    SpacesInConditionalStatement: false
    SpacesInContainerLiterals: true
    SpacesInCStyleCastParentheses: false
    SpacesInLineCommentPrefix:
    Minimum: 1
    Maximum: -1
    SpacesInParentheses: false
    SpacesInSquareBrackets: false
    Standard: Auto
    StatementAttributeLikeMacros:
• Q_EMIT
  StatementMacros:
• Q_UNUSED
• QT_REQUIRE_VERSION
  TabWidth: 4
  UseTab: ForIndentation
  WhitespaceSensitiveMacros:
• BOOST_PP_STRINGIZE
• CF_SWIFT_NAME
• NS_SWIFT_NAME
• PP_STRINGIZE
• STRINGIZE
  ...

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Søren Holm (sgh)

Clang-format 19 generates this :

struct DLL_PUBLIC SomeClas{SomeClass(){}};

however if I remove DLL_PUBLIC I get this:

struct SomeClas {
SomeClass() {}
};

This is my clang-format

---

Language: Cpp

BasedOnStyle: Google

AccessModifierOffset: -4
AlignAfterOpenBracket: Align
AlignArrayOfStructures: Left
AlignConsecutiveAssignments:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: true
AlignConsecutiveBitFields:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: false
AlignConsecutiveDeclarations:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: false
AlignConsecutiveMacros:
Enabled: false
AcrossEmptyLines: false
AcrossComments: false
AlignCompound: false
PadOperators: false
AlignEscapedNewlines: Left
AlignOperands: Align
AlignTrailingComments:
Kind: Always
OverEmptyLines: 0
AllowAllArgumentsOnNextLine: true
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortBlocksOnASingleLine: Empty
AllowShortCaseLabelsOnASingleLine: false
AllowShortEnumsOnASingleLine: true
AllowShortFunctionsOnASingleLine: Inline
AllowShortIfStatementsOnASingleLine: Never
AllowShortLambdasOnASingleLine: All
AllowShortLoopsOnASingleLine: false
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakAfterReturnType: None
AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: Yes
AttributeMacros:

• __capability
  BinPackArguments: true
  BinPackParameters: true
  BitFieldColonSpacing: Both
  BraceWrapping:
  AfterCaseLabel: false
  AfterClass: false
  AfterControlStatement: Never
  AfterEnum: false
  AfterExternBlock: false
  AfterFunction: false
  AfterNamespace: false
  AfterObjCDeclaration: false
  AfterStruct: false
  AfterUnion: false
  BeforeCatch: false
  BeforeElse: false
  BeforeLambdaBody: false
  BeforeWhile: false
  IndentBraces: false
  SplitEmptyFunction: true
  SplitEmptyRecord: true
  SplitEmptyNamespace: true
  BreakAfterAttributes: Never
  BreakAfterJavaFieldAnnotations: false
  BreakArrays: true
  BreakBeforeBinaryOperators: None
  BreakBeforeConceptDeclarations: Always
  BreakBeforeBraces: Attach
  BreakBeforeInlineASMColon: OnlyMultiline
  BreakBeforeTernaryOperators: true
  BreakConstructorInitializers: BeforeColon
  BreakInheritanceList: BeforeColon
  BreakStringLiterals: true
  ColumnLimit: 120
  CommentPragmas: '^ IWYU pragma:'
  CompactNamespaces: false
  ConstructorInitializerIndentWidth: 4
  ContinuationIndentWidth: 4
  Cpp11BracedListStyle: true
  DerivePointerAlignment: false
  DisableFormat: false
  EmptyLineAfterAccessModifier: Never
  EmptyLineBeforeAccessModifier: LogicalBlock
  ExperimentalAutoDetectBinPacking: false
  FixNamespaceComments: true
  ForEachMacros:
• foreach
• Q_FOREACH
• BOOST_FOREACH
  IfMacros:
• KJ_IF_MAYBE
  IncludeBlocks: Regroup
  IncludeCategories:
• Regex: '^<ext/.*.h>'
  Priority: 2
  SortPriority: 0
  CaseSensitive: false
• Regex: '^<.*.h>'
  Priority: 1
  SortPriority: 0
  CaseSensitive: false
• Regex: '^<.*'
  Priority: 2
  SortPriority: 0
  CaseSensitive: false
• Regex: '.*'
  Priority: 3
  SortPriority: 0
  CaseSensitive: false
  IncludeIsMainRegex: '(-_)?$'
  IncludeIsMainSourceRegex: ''
  IndentAccessModifiers: false
  IndentCaseBlocks: false
  IndentCaseLabels: true
  IndentExternBlock: AfterExternBlock
  IndentGotoLabels: true
  IndentPPDirectives: None
  IndentRequiresClause: true
  IndentWidth: 4
  IndentWrappedFunctionNames: false
  InsertBraces: false
  InsertNewlineAtEOF: false
  InsertTrailingCommas: None
  IntegerLiteralSeparator:
  Binary: 0
  BinaryMinDigits: 0
  Decimal: 0
  DecimalMinDigits: 0
  Hex: 0
  HexMinDigits: 0
  JavaScriptQuotes: Leave
  JavaScriptWrapImports: true
  KeepEmptyLinesAtTheStartOfBlocks: false
  LambdaBodyIndentation: Signature
  LineEnding: DeriveLF
  MacroBlockBegin: ''
  MacroBlockEnd: ''
  MaxEmptyLinesToKeep: 1
  NamespaceIndentation: None
  ObjCBinPackProtocolList: Never
  ObjCBlockIndentWidth: 2
  ObjCBreakBeforeNestedBlockParam: true
  ObjCSpaceAfterProperty: false
  ObjCSpaceBeforeProtocolList: true
  PackConstructorInitializers: NextLine
  PenaltyBreakAssignment: 2
  PenaltyBreakBeforeFirstCallParameter: 1
  PenaltyBreakComment: 300
  PenaltyBreakFirstLessLess: 120
  PenaltyBreakOpenParenthesis: 0
  PenaltyBreakString: 1000
  PenaltyBreakTemplateDeclaration: 10
  PenaltyExcessCharacter: 1000000
  PenaltyIndentedWhitespace: 0
  PenaltyReturnTypeOnItsOwnLine: 200
  PointerAlignment: Left
  PPIndentWidth: -1
  QualifierAlignment: Leave
  RawStringFormats:
• Language: Cpp
  Delimiters:
  • cc
  • CC
  • cpp
  • Cpp
  • CPP
  • 'c++'
  • 'C++'
    CanonicalDelimiter: ''
    BasedOnStyle: google
• Language: TextProto
  Delimiters:
  • pb
  • PB
  • proto
  • PROTO
    EnclosingFunctions:
  • EqualsProto
  • EquivToProto
  • PARSE_PARTIAL_TEXT_PROTO
  • PARSE_TEST_PROTO
  • PARSE_TEXT_PROTO
  • ParseTextOrDie
  • ParseTextProtoOrDie
  • ParseTestProto
  • ParsePartialTestProto
    CanonicalDelimiter: pb
    BasedOnStyle: google
    ReferenceAlignment: Pointer
    ReflowComments: false
    RemoveBracesLLVM: false
    RemoveSemicolon: false
    RequiresClausePosition: OwnLine
    RequiresExpressionIndentation: OuterScope
    SeparateDefinitionBlocks: Leave
    ShortNamespaceLines: 1
    SortIncludes: CaseSensitive
    SortJavaStaticImport: Before
    SortUsingDeclarations: LexicographicNumeric
    SpaceAfterCStyleCast: false
    SpaceAfterLogicalNot: false
    SpaceAfterTemplateKeyword: true
    SpaceAroundPointerQualifiers: Default
    SpaceBeforeAssignmentOperators: true
    SpaceBeforeCaseColon: false
    SpaceBeforeCpp11BracedList: false
    SpaceBeforeCtorInitializerColon: true
    SpaceBeforeInheritanceColon: true
    SpaceBeforeParens: ControlStatements
    SpaceBeforeParensOptions:
    AfterControlStatements: true
    AfterForeachMacros: true
    AfterFunctionDefinitionName: false
    AfterFunctionDeclarationName: false
    AfterIfMacros: true
    AfterOverloadedOperator: false
    AfterRequiresInClause: false
    AfterRequiresInExpression: false
    BeforeNonEmptyParentheses: false
    SpaceBeforeRangeBasedForLoopColon: true
    SpaceBeforeSquareBrackets: false
    SpaceInEmptyBlock: false
    SpaceInEmptyParentheses: false
    SpacesBeforeTrailingComments: 2
    SpacesInAngles: Never
    SpacesInConditionalStatement: false
    SpacesInContainerLiterals: true
    SpacesInCStyleCastParentheses: false
    SpacesInLineCommentPrefix:
    Minimum: 1
    Maximum: -1
    SpacesInParentheses: false
    SpacesInSquareBrackets: false
    Standard: Auto
    StatementAttributeLikeMacros:
• Q_EMIT
  StatementMacros:
• Q_UNUSED
• QT_REQUIRE_VERSION
  TabWidth: 4
  UseTab: ForIndentation
  WhitespaceSensitiveMacros:
• BOOST_PP_STRINGIZE
• CF_SWIFT_NAME
• NS_SWIFT_NAME
• PP_STRINGIZE
• STRINGIZE
  ...

[EugeneZelenko]

@sgh: Could you please elaborate?

[sgh]

Yes, but I closed the ticket because the following solved the issue.

AttributeMacros:

• DLL_PUBLIC

[alvestrand]

So the issue is that Clang-Format used to not require that all AttributeMacros be in the config file, and now it does?
Since an open issue has been marked as a duplicate of this issue, it might need to be reopened.

[sgh]

Wel, ok. It is your choice if you want to reopen it.

[alanzhao1]

Coming over from #123142 , I bisected this to 469c8a0

[owenca]

Duplicate of #117477.