Skip to content

[CIR][NFC][Testing] Fix test failure #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[CIR][NFC][Testing] Fix test failure #963

merged 1 commit into from
Oct 11, 2024

Conversation

ghehg
Copy link
Contributor

@ghehg ghehg commented Oct 11, 2024

as title.
Base on my experience of this type of test ,
The number of characters varies in this line as it's about full file path which changes during environment.

@ghehg ghehg marked this pull request as ready for review October 11, 2024 13:27
@smeenai
Copy link
Collaborator

smeenai commented Oct 11, 2024

Good catch! There might be flags we can set to avoid absolute paths as a follow-up, but I think we should ship this now to unbreak CI.

@smeenai smeenai merged commit f7d7959 into llvm:main Oct 11, 2024
9 checks passed
@bcardosolopes
Copy link
Member

Perfecto, thanks @ghehg

keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
as title.
Base on my experience of [this type of test(https://github.com/llvm/clangir/blob/a7ac2b4e2055e169d9f556abf5821a1ccab666cd/clang/test/CIR/CodeGen/attribute-annotate-multiple.cpp#L51),
The number of characters varies in this line as it's about full file
path which changes during environment.
lanza pushed a commit that referenced this pull request Nov 5, 2024
as title.
Base on my experience of [this type of test(https://github.com/llvm/clangir/blob/a7ac2b4e2055e169d9f556abf5821a1ccab666cd/clang/test/CIR/CodeGen/attribute-annotate-multiple.cpp#L51),
The number of characters varies in this line as it's about full file
path which changes during environment.
lanza pushed a commit that referenced this pull request Mar 18, 2025
as title.
Base on my experience of [this type of test(https://github.com/llvm/clangir/blob/a7ac2b4e2055e169d9f556abf5821a1ccab666cd/clang/test/CIR/CodeGen/attribute-annotate-multiple.cpp#L51),
The number of characters varies in this line as it's about full file
path which changes during environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants