Skip to content

[CIR][CIRGen][Builtin][Neon] Lower neon_vext_v and neon_vextq_v #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Oct 8, 2024

The PR also introduced a new test file to cover neon intrinsics that move data, which is a big category. This would the 5th neon test file. And we're committed to keep total number of neon test files within 6. This file uses another opt option instcombine, which makes test LLVM code more concise, and our -fclangir generated LLVM code would be identical to OG with this. It looks like OG did some instcombine optimization.

@ghehg ghehg marked this pull request as ready for review October 8, 2024 21:27
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 4c446b3 into llvm:main Oct 11, 2024
6 checks passed
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
…#951)

as title. 
There are two highlights of the PR

1. The PR introduced a new test file to cover neon intrinsics that move
data, which is a big category. This would the 5th neon test file. And
we're committed to keep total number of neon test files within 6. This
file uses another opt option instcombine, which makes test LLVM code
more concise, and our -fclangir generated LLVM code would be identical
to OG with this. It looks like OG did some instcombine optimization.

2. `getIntFromMLIRValue` helper function could be substituted by
[`mlir::cir::IntAttr getConstOpIntAttr` in
CIRGenAtomic.cpp](https://github.com/llvm/clangir/blob/24b24557c98d1c031572a567b658cfb6254f8a89/clang/lib/CIR/CodeGen/CIRGenAtomic.cpp#L337).
The function `mlir::cir::IntAttr getConstOpIntAttr` is doing more than
`getIntFromMLIRValue`, and there is FIXME in the comment, so not sure if
we should just use `mlir::cir::IntAttr getConstOpIntAttr`, either is
fine with me.
lanza pushed a commit that referenced this pull request Nov 5, 2024
as title. 
There are two highlights of the PR

1. The PR introduced a new test file to cover neon intrinsics that move
data, which is a big category. This would the 5th neon test file. And
we're committed to keep total number of neon test files within 6. This
file uses another opt option instcombine, which makes test LLVM code
more concise, and our -fclangir generated LLVM code would be identical
to OG with this. It looks like OG did some instcombine optimization.

2. `getIntFromMLIRValue` helper function could be substituted by
[`mlir::cir::IntAttr getConstOpIntAttr` in
CIRGenAtomic.cpp](https://github.com/llvm/clangir/blob/24b24557c98d1c031572a567b658cfb6254f8a89/clang/lib/CIR/CodeGen/CIRGenAtomic.cpp#L337).
The function `mlir::cir::IntAttr getConstOpIntAttr` is doing more than
`getIntFromMLIRValue`, and there is FIXME in the comment, so not sure if
we should just use `mlir::cir::IntAttr getConstOpIntAttr`, either is
fine with me.
lanza pushed a commit that referenced this pull request Mar 18, 2025
as title. 
There are two highlights of the PR

1. The PR introduced a new test file to cover neon intrinsics that move
data, which is a big category. This would the 5th neon test file. And
we're committed to keep total number of neon test files within 6. This
file uses another opt option instcombine, which makes test LLVM code
more concise, and our -fclangir generated LLVM code would be identical
to OG with this. It looks like OG did some instcombine optimization.

2. `getIntFromMLIRValue` helper function could be substituted by
[`mlir::cir::IntAttr getConstOpIntAttr` in
CIRGenAtomic.cpp](https://github.com/llvm/clangir/blob/24b24557c98d1c031572a567b658cfb6254f8a89/clang/lib/CIR/CodeGen/CIRGenAtomic.cpp#L337).
The function `mlir::cir::IntAttr getConstOpIntAttr` is doing more than
`getIntFromMLIRValue`, and there is FIXME in the comment, so not sure if
we should just use `mlir::cir::IntAttr getConstOpIntAttr`, either is
fine with me.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants