Skip to content

[CIR][IR] harden the get_member verifier #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

[CIR][IR] harden the get_member verifier #330

merged 1 commit into from
Nov 22, 2023

Conversation

@gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented Nov 21, 2023 •
edited
Loading

I think it's time to claim that CIR supports recursive types (many thanks to #303 and to @sitio-couto :) )
And we can bring back the get_member verification back, with no checks for incomplete types. What do you think?

And we can close #256 as well

bcardosolopes
bcardosolopes approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @sitio-couto any input?

sitio-couto
sitio-couto approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@sitio-couto sitio-couto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcardosolopes LGTM too!

@bcardosolopes bcardosolopes merged commit fe700fe into llvm:main Nov 22, 2023
lanza pushed a commit that referenced this pull request Dec 20, 2023
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
b4de473 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
lanza pushed a commit that referenced this pull request Jan 29, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
1a32749 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
lanza pushed a commit that referenced this pull request Mar 23, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
e01227d 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (llvm#330)
39694bf 
I think it's time to claim that CIR supports recursive types (many
thanks to llvm#303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close llvm#256 as well
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (llvm#330)
5dab8a1 
I think it's time to claim that CIR supports recursive types (many
thanks to llvm#303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close llvm#256 as well
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
bd9a521 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
311c714 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (llvm#330)
4add88c 
I think it's time to claim that CIR supports recursive types (many
thanks to llvm#303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close llvm#256 as well
lanza pushed a commit that referenced this pull request Apr 29, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
792e00c 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (llvm#330)
0e148f8 
I think it's time to claim that CIR supports recursive types (many
thanks to llvm#303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close llvm#256 as well
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (llvm#330)
6f691fe 
I think it's time to claim that CIR supports recursive types (many
thanks to llvm#303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close llvm#256 as well
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (llvm#330)
b075ba3 
I think it's time to claim that CIR supports recursive types (many
thanks to llvm#303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close llvm#256 as well
lanza pushed a commit that referenced this pull request Nov 5, 2024
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
f114eab 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
lanza pushed a commit that referenced this pull request Mar 18, 2025
@gitoleg @lanza
[CIR][IR] Harden get_member verifier (#330)
3b927e6 
I think it's time to claim that CIR supports recursive types (many
thanks to #303 and to @sitio-couto :) )
And we can bring back the `get_member` verification back, with no checks
for incomplete types. What do you think?

And we can close #256 as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@sitio-couto sitio-couto sitio-couto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GetMemberOp verification failure on recursive types

3 participants

@gitoleg @bcardosolopes @sitio-couto