[CIR] Added support for __builtin_ia32_pslldqi_byteshift
#1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizardengineer
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
tommymcm
reviewed
Sep 2, 2025
Comment on lines
55
to
67
| // CHECK-LABEL: @_Z23test_pslldqi128_shift20Dv2_x | ||
| __m128i test_pslldqi128_shift20(__m128i a) { | ||
| // Should also return zero | ||
| // CHECK: %{{.*}} = cir.const #cir.zero : !cir.vector<!s64i x 2> | ||
| return __builtin_ia32_pslldqi128_byteshift(a, 20); | ||
| } | ||
|
|
||
| // CHECK-LABEL: @_Z28test_pslldqi128_masked_shiftDv2_x | ||
| __m128i test_pslldqi128_masked_shift(__m128i a) { | ||
| // 250 > 16, so should return zero | ||
| // CHECK: %{{.*}} = cir.const #cir.zero : !cir.vector<!s64i x 2> | ||
| return __builtin_ia32_pslldqi128_byteshift(a, 250); | ||
| } |
There was a problem hiding this comment.
Is there a reason we need both of these tests?
Comment on lines
1
to
2
| // RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir -target-feature +avx512f | ||
| // RUN: FileCheck --input-file=%t.cir %s |
There was a problem hiding this comment.
Could we add cir-to-llvm (LLVM) and OG codegen (OGCG) tests?
|
Closes #1880 |
|
lgtm, after @tommymcm comments are resolved |
wizardengineer
force-pushed
the
julius/pslldqi-support
branch
from
fc93690 to
011131f
Compare
wizardengineer
commented
Sep 4, 2025
| // LLVM: store <2 x i64> zeroinitializer, ptr %{{.*}}, align 16 | ||
| // OGCG: ret <2 x i64> zeroinitializer | ||
| return __builtin_ia32_pslldqi128_byteshift(a, 240); | ||
| } |
There was a problem hiding this comment.
I think we should still keep this test? I do agree the tests previously was redundant, but I only did so for the sake of stress testing my implementation in order to make sure we catch the issues now rather than later.
tommymcm
pushed a commit
to tommymcm/clangir
that referenced
this pull request
Sep 5, 2025
**Related Issue**: llvm#1880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #1880