-
Notifications
You must be signed in to change notification settings - Fork 168
[CIR][CIRGen] Fix builtin IIT Integer signedness using AST information #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RiverDave
wants to merge
4
commits into
llvm:main
Choose a base branch
from
RiverDave:dave/fix-iit-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd2fc0d
to
121909e
Compare
bcardosolopes
requested changes
Sep 3, 2025
8699d72
to
6e489c8
Compare
✅ With the latest revision this PR passed the C/C++ code formatter. |
6e489c8
to
800dd59
Compare
800dd59
to
b086973
Compare
b086973
to
dbf5618
Compare
bcardosolopes
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, LGTM once a few final nits get address - thanks for your patience
9a5b387
to
5b867ed
Compare
bcardosolopes
approved these changes
Sep 12, 2025
5b867ed
to
a609f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a blocker when working on PTX intrinsics.
One of the problems we have whenever we want to emit generic builtins with the current infrastructure (IIT Descriptors) is that it doesn't allow us to determine signedness in scalar types. When we emit these builtins we seem to type check param/return types:
if (argType != intrinsicType.getInput(i))
. In our current approach to decode a type from IIT we force signedness:I was finding cases where the function definition would specify x parameter as unsigned but when calling this function with the right type, it would trigger an NYI statement we had encoded(This is not case for OG as by design, LLVMIR does not contain that information):
Example issue:
To solve this, I've used a very naive approach, we know that front-end contains all signedness information we need. I've used AST information (I've specifically extracted the Function Decl) to determine whether if we should enforce signedness or not based on the definition it was declared with.
I've also added the respective CUDA test that was being affected by this issue. along with the implementing the rest of the NYI block related to this.